Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

views/window/window_gtk.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_WINDOW_WINDOW_GTK_H_
 #define VIEWS_WINDOW_WINDOW_GTK_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "views/widget/widget_gtk.h"
@@ skipping 42 matching lines @@
   virtual void SetIsAlwaysOnTop(bool always_on_top);
   virtual NonClientFrameView* CreateFrameViewForWindow();
   virtual void UpdateFrameAfterFrameChange();
   virtual WindowDelegate* GetDelegate() const;
   virtual NonClientView* GetNonClientView() const;
   virtual ClientView* GetClientView() const;
   virtual gfx::NativeWindow GetNativeWindow() const;
   virtual bool ShouldUseNativeFrame() const;
   virtual void FrameTypeChanged();
 
-  virtual Window* AsWindow() { return this; }
-  virtual const Window* AsWindow() const { return this; }
+  virtual Window* AsWindow();
+  virtual const Window* AsWindow() const;
 
   // Overridden from WidgetGtk:
   virtual gboolean OnButtonPress(GtkWidget* widget, GdkEventButton* event);
   virtual gboolean OnConfigureEvent(GtkWidget* widget,
                                     GdkEventConfigure* event);
   virtual gboolean OnMotionNotify(GtkWidget* widget, GdkEventMotion* event);
   virtual void OnSizeAllocate(GtkWidget* widget, GtkAllocation* allocation);
   virtual gboolean OnWindowStateEvent(GtkWidget* widget,
                                       GdkEventWindowState* event);
   virtual gboolean OnLeaveNotify(GtkWidget* widget, GdkEventCrossing* event);
@@ skipping 44 matching lines @@
 
   // Set to true if the window is in the process of closing.
   bool window_closed_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowGtk);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_WINDOW_WINDOW_GTK_H_