Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6079009: Move some misc thread-related stuff from base to base/thread and into the bas... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., apatrick_chromium, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move some misc thread-related stuff from base to base/thread and into the base namespace. This does not move the "hard" thread stuff (thread.h). TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70315

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1610 lines, -1598 lines) Patch
M base/base.gyp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M base/base.gypi View 1 4 chunks +8 lines, -8 lines 0 comments Download
M base/lazy_instance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/non_thread_safe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/simple_thread.h View 1 chunk +0 lines, -182 lines 0 comments Download
D base/simple_thread.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D base/simple_thread_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M base/thread_checker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/thread_collision_warner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/thread_local_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/thread_local_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A base/threading/simple_thread.h View 1 chunk +182 lines, -0 lines 0 comments Download
A base/threading/simple_thread.cc View 1 chunk +152 lines, -0 lines 0 comments Download
A base/threading/simple_thread_unittest.cc View 1 chunk +170 lines, -0 lines 0 comments Download
A base/threading/watchdog.h View 1 chunk +98 lines, -0 lines 0 comments Download
A base/threading/watchdog.cc View 1 chunk +144 lines, -0 lines 0 comments Download
A base/threading/watchdog_unittest.cc View 1 chunk +140 lines, -0 lines 0 comments Download
A base/threading/worker_pool.h View 1 chunk +35 lines, -0 lines 0 comments Download
A base/threading/worker_pool_posix.h View 1 chunk +89 lines, -0 lines 0 comments Download
A base/threading/worker_pool_posix.cc View 1 chunk +169 lines, -0 lines 0 comments Download
A base/threading/worker_pool_posix_unittest.cc View 1 chunk +268 lines, -0 lines 0 comments Download
A base/threading/worker_pool_unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A base/threading/worker_pool_win.cc View 1 chunk +40 lines, -0 lines 0 comments Download
D base/watchdog.h View 1 chunk +0 lines, -94 lines 0 comments Download
D base/watchdog.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D base/watchdog_unittest.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D base/worker_pool.h View 1 chunk +0 lines, -31 lines 0 comments Download
D base/worker_pool_posix.h View 1 chunk +0 lines, -89 lines 0 comments Download
D base/worker_pool_posix.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D base/worker_pool_posix_unittest.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D base/worker_pool_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D base/worker_pool_win.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/jankometer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/keystone_glue.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/gpu/gpu_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper_devices.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/cert_verifier.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/dnsrr_resolver.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/file_stream_posix.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M net/base/host_resolver_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/base/test_completion_callback_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/file_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/polling_proxy_config_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/flip_server/flip_in_mem_edsm_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/audio_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
TBR
9 years, 11 months ago (2010-12-30 18:08:24 UTC) #1
Timur Iskhodzhanov
Please consider doing "svn mv" next time (it preserves history) Currently all lines of base/worker_pool_unittest.cc ...
9 years, 11 months ago (2011-01-03 19:48:19 UTC) #2
brettw
On Mon, Jan 3, 2011 at 11:48 AM, <timurrrr@chromium.org> wrote: > Please consider doing "svn ...
9 years, 11 months ago (2011-01-03 19:57:48 UTC) #3
darin (slow to review)
9 years, 11 months ago (2011-01-03 21:40:01 UTC) #4
LGTM

On Thu, Dec 30, 2010 at 10:08 AM, <brettw@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> TBR
>
> Description:
> Move some misc thread-related stuff from base to base/thread and into the
> base
> namespace. This does not move the "hard" thread stuff (thread.h).
>
> TEST=it compiles
> BUG=none
>
> Please review this at http://codereview.chromium.org/6079009/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/base.gyp
>  M     base/base.gypi
>  M     base/lazy_instance_unittest.cc
>  M     base/metrics/stats_table_unittest.cc
>  M     base/non_thread_safe_unittest.cc
>  D     base/simple_thread.h
>  D     base/simple_thread.cc
>  D     base/simple_thread_unittest.cc
>  M     base/thread_checker_unittest.cc
>  M     base/thread_collision_warner_unittest.cc
>  M     base/thread_local_storage_unittest.cc
>  M     base/thread_local_unittest.cc
>  A     base/threading/simple_thread.h
>  A     base/threading/simple_thread.cc
>  A     base/threading/simple_thread_unittest.cc
>  A     base/threading/watchdog.h
>  A     base/threading/watchdog.cc
>  A     base/threading/watchdog_unittest.cc
>  A     base/threading/worker_pool.h
>  A     base/threading/worker_pool_posix.h
>  A     base/threading/worker_pool_posix.cc
>  A     base/threading/worker_pool_posix_unittest.cc
>  A     base/threading/worker_pool_unittest.cc
>  A     base/threading/worker_pool_win.cc
>  D     base/watchdog.h
>  D     base/watchdog.cc
>  D     base/watchdog_unittest.cc
>  D     base/worker_pool.h
>  D     base/worker_pool_posix.h
>  D     base/worker_pool_posix.cc
>  D     base/worker_pool_posix_unittest.cc
>  D     base/worker_pool_unittest.cc
>  D     base/worker_pool_win.cc
>  M     chrome/browser/jankometer.cc
>  M     chrome/browser/printing/printing_layout_uitest.cc
>  M     chrome/browser/renderer_host/render_message_filter.cc
>  M     chrome/browser/ui/cocoa/keystone_glue.mm
>  M     chrome/gpu/gpu_thread.cc
>  M     chrome/renderer/pepper_devices.h
>  M     net/base/cert_verifier.cc
>  M     net/base/dnsrr_resolver.cc
>  M     net/base/file_stream_posix.cc
>  M     net/base/host_resolver_impl.cc
>  M     net/base/keygen_handler_unittest.cc
>  M     net/base/test_completion_callback_unittest.cc
>  M     net/disk_cache/backend_impl.cc
>  M     net/disk_cache/file_posix.cc
>  M     net/proxy/polling_proxy_config_service.cc
>  M     net/tools/flip_server/flip_in_mem_edsm_server.cc
>  M     net/url_request/url_request_file_job.cc
>  M     ppapi/proxy/ppb_audio_proxy.cc
>  M     ppapi/shared_impl/audio_impl.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698