Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 125109: Refactor the PlatformContext layer to have only one class. (Closed)

Created:
11 years, 6 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Refactor the PlatformContext layer to have only one class. Previously we had three classes of PlatformCanvas*, one for each platform. Then we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the specific platform. This means that it was almost impossible to forward-declare PlatformCanvas and there were a bunch of unnecessary includes of platform_canvas.h in header files. This change makes there be only one platform_canvas.h header with ifdefs, which removes a decent amount of duplicated code. There is a platform-independent file, and one platform-dependent file of platform_canvas for each platform. I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in this case I kept the separate headers since there was much less overlap. I also broke out CanvasPaint into separate headers so this template doesn't need to be included all over the project (only a couple of files actually need it). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1512 lines, -1636 lines) Patch
M app/gfx/canvas.h View 1 chunk +0 lines, -4 lines 0 comments Download
M app/gfx/canvas_linux.cc View 3 chunks +5 lines, -3 lines 0 comments Download
A app/gfx/canvas_paint.h View 1 chunk +22 lines, -0 lines 0 comments Download
M app/gfx/canvas_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/gfx/native_theme.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/gfx/native_theme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/sad_tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printed_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/win_printing_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/theme_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_printer_driver_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device.h View 2 chunks +7 lines, -14 lines 0 comments Download
M skia/ext/bitmap_platform_device_linux.h View 3 chunks +13 lines, -15 lines 0 comments Download
M skia/ext/bitmap_platform_device_linux.cc View 5 chunks +29 lines, -27 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 6 chunks +13 lines, -13 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 7 chunks +35 lines, -36 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 5 chunks +20 lines, -14 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 12 chunks +48 lines, -33 lines 0 comments Download
A skia/ext/canvas_paint.h View 1 chunk +17 lines, -0 lines 0 comments Download
A skia/ext/canvas_paint_linux.h View 1 chunk +99 lines, -0 lines 0 comments Download
A skia/ext/canvas_paint_win.h View 1 chunk +132 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +109 lines, -13 lines 0 comments Download
A skia/ext/platform_canvas.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas_linux.h View 1 chunk +0 lines, -154 lines 0 comments Download
M skia/ext/platform_canvas_linux.cc View 3 chunks +18 lines, -41 lines 0 comments Download
M skia/ext/platform_canvas_mac.h View 1 chunk +0 lines, -96 lines 0 comments Download
M skia/ext/platform_canvas_mac.cc View 1 chunk +27 lines, -77 lines 0 comments Download
M skia/ext/platform_canvas_win.h View 1 chunk +10 lines, -203 lines 0 comments Download
M skia/ext/platform_canvas_win.cc View 4 chunks +21 lines, -49 lines 0 comments Download
M skia/ext/platform_device.h View 2 chunks +5 lines, -13 lines 0 comments Download
M skia/ext/platform_device_linux.h View 2 chunks +4 lines, -2 lines 0 comments Download
M skia/ext/platform_device_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/platform_device_mac.h View 2 chunks +4 lines, -2 lines 0 comments Download
M skia/ext/platform_device_mac.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M skia/ext/platform_device_win.h View 2 chunks +4 lines, -2 lines 0 comments Download
M skia/ext/platform_device_win.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M skia/ext/vector_canvas.h View 2 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/vector_canvas.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M skia/ext/vector_device.h View 1 chunk +0 lines, -120 lines 0 comments Download
M skia/ext/vector_device.cc View 1 chunk +0 lines, -612 lines 0 comments Download
A skia/ext/vector_platform_device_win.h View 1 chunk +120 lines, -0 lines 0 comments Download
A skia/ext/vector_platform_device_win.cc View 1 chunk +645 lines, -0 lines 0 comments Download
M skia/skia.gyp View 2 chunks +3 lines, -5 lines 0 comments Download
M views/controls/tree/tree_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/root_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/root_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/window/window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/public/WebCanvas.h View 1 chunk +5 lines, -16 lines 0 comments Download
M webkit/glue/webframe_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/webwidget_host.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host_gtk.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698