Split the virtual frame into heavy and light versions....

Split the virtual frame into heavy and light versions.
The heavy version is for x86 and x64.  The light version
is for ARM and MIPS.  Remove the elements_ array from the
virtual frame in the light version.  More simplifications
to come, followed by light register allocation.

Committed: http://code.google.com/p/v8/source/detail?r=4272

[Kasper Lund, 2010-03-22 13:12:35]

LGTM (with the appropriate .gyp changes), but it's somewhat hard to review with
all the code that's being moved around. I trust that the -heavy versions are the
only slightly modified from the originals. I've reviewed the rest more
thoroughly.

http://codereview.chromium.org/1164002/diff/1/10
File src/SConscript (right):

http://codereview.chromium.org/1164002/diff/1/10#newcode132
src/SConscript:132: jump-target-light.cc
You need to update at least the .gyp file too (and possibly other project
files).

http://codereview.chromium.org/1164002/diff/1/16
File src/arm/virtual-frame-arm.cc (right):

http://codereview.chromium.org/1164002/diff/1/16#newcode51
src/arm/virtual-frame-arm.cc:51: // All elements are in memory on ARM (ie,
synced).
I guess this is called on ARM. Do you want to try to inline it?

http://codereview.chromium.org/1164002/diff/1/17
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/1164002/diff/1/17#newcode335
src/arm/virtual-frame-arm.h:335: int element_count_;
Maybe add a comment here? Number of elements on the stack? I guess so.

http://codereview.chromium.org/1164002/diff/1/7
File src/jump-target-heavy.cc (right):

http://codereview.chromium.org/1164002/diff/1/7#newcode46
src/jump-target-heavy.cc:46: #ifdef DEBUG
Maybe move these nasty macros above the first method?

http://codereview.chromium.org/1164002/diff/1/7#newcode47
src/jump-target-heavy.cc:47: #define DECLARE_ARGCHECK_VARS(name)                
               \
Maybe add a comment here on what these macros intend to accomplish.

http://codereview.chromium.org/1164002/diff/1/2
File src/jump-target-inl.h (right):

http://codereview.chromium.org/1164002/diff/1/2#newcode38
src/jump-target-inl.h:38: namespace v8 {
Extra newline before namespace.

[Kevin Millikin (Chromium), 2010-03-22 13:13:35]

LGTM as a start.

http://codereview.chromium.org/1164002/diff/1/10
File src/SConscript (right):

http://codereview.chromium.org/1164002/diff/1/10#newcode131
src/SConscript:131: fast-codegen.cc
I think these files in the main src/ directory should either always come before
or always after the ones in subdirectories (preferably before).

If you alphabetize them along with the rest, some will be before and some after
and it's probably better to have them together.

http://codereview.chromium.org/1164002/diff/1/18
File src/arm/jump-target-arm.cc (right):

http://codereview.chromium.org/1164002/diff/1/18#newcode205
src/arm/jump-target-arm.cc:205: UNREACHABLE();
UNIMPLEMENTED?

http://codereview.chromium.org/1164002/diff/1/9
File src/jump-target-light-inl.h (right):

http://codereview.chromium.org/1164002/diff/1/9#newcode37
src/jump-target-light-inl.h:37: UNREACHABLE();
UNIMPLEMENTED?

[Erik Corry, 2010-03-25 12:40:52]

http://codereview.chromium.org/1164002/diff/1/16
File src/arm/virtual-frame-arm.cc (right):

http://codereview.chromium.org/1164002/diff/1/16#newcode51
src/arm/virtual-frame-arm.cc:51: // All elements are in memory on ARM (ie,
synced).
On 2010/03/22 13:12:35, Kasper Lund wrote:
> I guess this is called on ARM. Do you want to try to inline it?

Not called.

Removed.

http://codereview.chromium.org/1164002/diff/1/7
File src/jump-target-heavy.cc (right):

http://codereview.chromium.org/1164002/diff/1/7#newcode46
src/jump-target-heavy.cc:46: #ifdef DEBUG
On 2010/03/22 13:12:35, Kasper Lund wrote:
> Maybe move these nasty macros above the first method?

They were only used in 2 places so I got rid of them instead.