Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, GeorgeY, ncarter (slow), akalin, Raghu Simha, mihaip+watch_chromium.org, Aaron Boodman, dyu1, dhollowa+watch_chromium.org, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

RefCounted types should not have public destructors, chrome/browser/ part 2 BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133847

Patch Set 1 #

Patch Set 2 : Implementation ordering fixes as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+663 lines, -591 lines) Patch
M chrome/browser/sync/glue/app_notification_data_type_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/app_notification_data_type_controller.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 3 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 3 chunks +40 lines, -40 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 1 3 chunks +34 lines, -35 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/browser_thread_model_worker.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/browser_thread_model_worker.cc View 1 5 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/data_type_controller.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/data_type_controller.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/data_type_controller_mock.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 1 6 chunks +81 lines, -80 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_mock.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc View 1 4 chunks +83 lines, -83 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_mock.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 1 8 chunks +152 lines, -150 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_mock.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/password_model_worker.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_worker.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/session_data_type_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 6 chunks +42 lines, -42 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.cc View 1 3 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
zea: PTAL
8 years, 8 months ago (2012-04-13 08:58:52 UTC) #1
Nicolas Zea
LGTM, thanks!
8 years, 8 months ago (2012-04-13 14:29:21 UTC) #2
Ryan Sleevi
nzea: This CL now also shifts around the definitions to match their declarations, per the ...
8 years, 8 months ago (2012-04-24 23:53:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10071033/4001
8 years, 8 months ago (2012-04-24 23:57:05 UTC) #4
commit-bot: I haz the power
Try job failure for 10071033-4001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-25 01:05:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10071033/4001
8 years, 8 months ago (2012-04-25 01:09:26 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 02:40:44 UTC) #7 
Change committed as 133847

Powered by Google App Engine
This is Rietveld 408576698