chrome/browser/sync/glue/frontend_data_type_controller.h - Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/frontend_data_type_controller.h

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/extension_setting_data_type_controller.cc ('k') | chrome/browser/sync/glue/frontend_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/frontend_data_type_controller.h

diff --git a/chrome/browser/sync/glue/frontend_data_type_controller.h b/chrome/browser/sync/glue/frontend_data_type_controller.h

index 8b46978ce233595145623bbde3da89851422f8d6..1baac4b46f49769450153735daf8c2c6013eaba9 100644

--- a/chrome/browser/sync/glue/frontend_data_type_controller.h

+++ b/chrome/browser/sync/glue/frontend_data_type_controller.h

@@ -41,7 +41,6 @@ class FrontendDataTypeController : public DataTypeController {

ProfileSyncComponentsFactory* profile_sync_factory,

Profile* profile,

ProfileSyncService* sync_service);

- virtual ~FrontendDataTypeController();

// DataTypeController interface.

virtual void Start(const StartCallback& start_callback) OVERRIDE;

@@ -59,8 +58,11 @@ class FrontendDataTypeController : public DataTypeController {

const std::string& message) OVERRIDE;

protected:

+ friend class FrontendDataTypeControllerMock;

// For testing only.

FrontendDataTypeController();

+ virtual ~FrontendDataTypeController();

// Kick off any dependent services that need to be running before we can

// associate models. The default implementation is a no-op.