Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/sync/glue/data_type_controller.h

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/data_type_controller.h
diff --git a/chrome/browser/sync/glue/data_type_controller.h b/chrome/browser/sync/glue/data_type_controller.h
index 81f7c68b4ee02efe7b5a996f4ffb776a835ad085..2be6064ca679a53be1a74fa74cfbb6175d7efd62 100644
--- a/chrome/browser/sync/glue/data_type_controller.h
+++ b/chrome/browser/sync/glue/data_type_controller.h
@@ -105,18 +105,18 @@ class DataTypeController
syncable::ModelType type) OVERRIDE;
protected:
+ friend struct content::BrowserThread::DeleteOnThread<
+ content::BrowserThread::UI>;
+ friend class base::DeleteHelper<DataTypeController>;
+
+ virtual ~DataTypeController() {}
+
// Handles the reporting of unrecoverable error. It records stuff in
// UMA and reports to breakpad.
// Virtual for testing purpose.
virtual void RecordUnrecoverableError(
const tracked_objects::Location& from_here,
const std::string& message);
-
- friend struct content::BrowserThread::DeleteOnThread<
- content::BrowserThread::UI>;
- friend class base::DeleteHelper<DataTypeController>;
-
- virtual ~DataTypeController() {}
};
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/browser_thread_model_worker.cc ('k') | chrome/browser/sync/glue/data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698