chrome/browser/sync/glue/extension_setting_data_type_controller.cc - Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/extension_setting_data_type_controller.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/extension_setting_data_type_controller.h ('k') | chrome/browser/sync/glue/frontend_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/extension_setting_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/extension_setting_data_type_controller.cc b/chrome/browser/sync/glue/extension_setting_data_type_controller.cc

index 352d4c7b3290054e56c32f70e27f704e6a10e2c1..f29adaf0a03d6d1c6e88e6f5e5f622f52553f26e 100644

--- a/chrome/browser/sync/glue/extension_setting_data_type_controller.cc

+++ b/chrome/browser/sync/glue/extension_setting_data_type_controller.cc

@@ -34,8 +34,6 @@ ExtensionSettingDataTypeController::ExtensionSettingDataTypeController(

type == syncable::APP_SETTINGS);

}

-ExtensionSettingDataTypeController::~ExtensionSettingDataTypeController() {}

syncable::ModelType ExtensionSettingDataTypeController::type() const {

return type_;

}

@@ -45,6 +43,8 @@ ExtensionSettingDataTypeController::model_safe_group() const {

return browser_sync::GROUP_FILE;

}

+ExtensionSettingDataTypeController::~ExtensionSettingDataTypeController() {}

bool ExtensionSettingDataTypeController::PostTaskOnBackendThread(

const tracked_objects::Location& from_here,

const base::Closure& task) {