chrome/browser/sync/glue/search_engine_data_type_controller.cc - Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/search_engine_data_type_controller.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/search_engine_data_type_controller.h ('k') | chrome/browser/sync/glue/session_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/search_engine_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/search_engine_data_type_controller.cc b/chrome/browser/sync/glue/search_engine_data_type_controller.cc

index 504494cb6dd76052d26e2b6c96e2ffc89dd035c3..16728ccf36678279d330d6d10fc0e0b2e0ebabd6 100644

--- a/chrome/browser/sync/glue/search_engine_data_type_controller.cc

+++ b/chrome/browser/sync/glue/search_engine_data_type_controller.cc

@@ -28,9 +28,6 @@ SearchEngineDataTypeController::SearchEngineDataTypeController(

sync_service) {

}

-SearchEngineDataTypeController::~SearchEngineDataTypeController() {

void SearchEngineDataTypeController::Observe(

int type,

const content::NotificationSource& source,

@@ -43,6 +40,8 @@ void SearchEngineDataTypeController::Observe(

Associate();

}

+SearchEngineDataTypeController::~SearchEngineDataTypeController() {}

// We want to start the TemplateURLService before we begin associating.

bool SearchEngineDataTypeController::StartModels() {

// If the TemplateURLService is loaded, continue with association. We force