Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc b/chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc
index f24a46910dd1ead331735afade29d040ef5db65c..98a358f09c836b8049315f0a79c95057d38cdff6 100644
--- a/chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc
@@ -29,15 +29,6 @@ using testing::Return;
using testing::SetArgumentPointee;
namespace browser_sync {
-namespace {
-
-ACTION(MakeSharedChangeProcessor) {
- return new SharedChangeProcessor();
-}
-
-ACTION_P(ReturnAndRelease, change_processor) {
- return change_processor->release();
-}
class TestAppNotificationDataTypeController
: public AppNotificationDataTypeController {
@@ -57,9 +48,21 @@ class TestAppNotificationDataTypeController
}
private:
+ virtual ~TestAppNotificationDataTypeController() {}
+
scoped_refptr<AppNotificationManager> manager_;
};
+namespace {
+
+ACTION(MakeSharedChangeProcessor) {
+ return new SharedChangeProcessor();
+}
+
+ACTION_P(ReturnAndRelease, change_processor) {
+ return change_processor->release();
+}
+
class SyncAppNotificationDataTypeControllerTest
: public testing::Test {
public:

Powered by Google App Engine
This is Rietveld 408576698