Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Side by Side Diff: chrome/browser/sync/glue/history_model_worker.h

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_HISTORY_MODEL_WORKER_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_HISTORY_MODEL_WORKER_H_
6 #define CHROME_BROWSER_SYNC_GLUE_HISTORY_MODEL_WORKER_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_HISTORY_MODEL_WORKER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "sync/engine/model_safe_worker.h" 9 #include "sync/engine/model_safe_worker.h"
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/callback_forward.h" 12 #include "base/callback_forward.h"
13 #include "base/compiler_specific.h" 13 #include "base/compiler_specific.h"
14 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
15 #include "chrome/browser/cancelable_request.h" 15 #include "chrome/browser/cancelable_request.h"
16 16
17 class HistoryService; 17 class HistoryService;
18 18
19 namespace browser_sync { 19 namespace browser_sync {
20 20
21 // A ModelSafeWorker for history models that accepts requests 21 // A ModelSafeWorker for history models that accepts requests
22 // from the syncapi that need to be fulfilled on the history thread. 22 // from the syncapi that need to be fulfilled on the history thread.
23 class HistoryModelWorker : public browser_sync::ModelSafeWorker { 23 class HistoryModelWorker : public browser_sync::ModelSafeWorker {
24 public: 24 public:
25 explicit HistoryModelWorker(HistoryService* history_service); 25 explicit HistoryModelWorker(HistoryService* history_service);
26 virtual ~HistoryModelWorker();
27 26
28 // ModelSafeWorker implementation. Called on syncapi SyncerThread. 27 // ModelSafeWorker implementation. Called on syncapi SyncerThread.
29 virtual SyncerError DoWorkAndWaitUntilDone( 28 virtual SyncerError DoWorkAndWaitUntilDone(
30 const WorkCallback& work) OVERRIDE; 29 const WorkCallback& work) OVERRIDE;
31 virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE; 30 virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE;
32 31
33 private: 32 private:
33 virtual ~HistoryModelWorker();
34
34 scoped_refptr<HistoryService> history_service_; 35 scoped_refptr<HistoryService> history_service_;
35 // Helper object to make sure we don't leave tasks running on the history 36 // Helper object to make sure we don't leave tasks running on the history
36 // thread. 37 // thread.
37 CancelableRequestConsumerT<int, 0> cancelable_consumer_; 38 CancelableRequestConsumerT<int, 0> cancelable_consumer_;
38 DISALLOW_COPY_AND_ASSIGN(HistoryModelWorker); 39 DISALLOW_COPY_AND_ASSIGN(HistoryModelWorker);
39 }; 40 };
40 41
41 } // namespace browser_sync 42 } // namespace browser_sync
42 43
43 #endif // CHROME_BROWSER_SYNC_GLUE_HISTORY_MODEL_WORKER_H_ 44 #endif // CHROME_BROWSER_SYNC_GLUE_HISTORY_MODEL_WORKER_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc ('k') | chrome/browser/sync/glue/history_model_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698