chrome/browser/sync/glue/password_model_worker.h - Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/password_model_worker.h

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/password_data_type_controller.cc ('k') | chrome/browser/sync/glue/password_model_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/password_model_worker.h

diff --git a/chrome/browser/sync/glue/password_model_worker.h b/chrome/browser/sync/glue/password_model_worker.h

index 5b0cbcb95e154b4bc2f578b28ade69050453c053..d9e62030ade638d3eca4e746ecb4b48a336c5144 100644

--- a/chrome/browser/sync/glue/password_model_worker.h

+++ b/chrome/browser/sync/glue/password_model_worker.h

@@ -28,7 +28,6 @@ class PasswordModelWorker : public browser_sync::ModelSafeWorker {

public:

explicit PasswordModelWorker(

const scoped_refptr<PasswordStore>& password_store);

- virtual ~PasswordModelWorker();

// ModelSafeWorker implementation. Called on syncapi SyncerThread.

virtual SyncerError DoWorkAndWaitUntilDone(

@@ -36,6 +35,8 @@ class PasswordModelWorker : public browser_sync::ModelSafeWorker {

virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE;

private:

+ virtual ~PasswordModelWorker();

void CallDoWorkAndSignalTask(

const WorkCallback& work,

base::WaitableEvent* done,

« no previous file with comments | « chrome/browser/sync/glue/password_data_type_controller.cc ('k') | chrome/browser/sync/glue/password_model_worker.cc » ('j') | no next file with comments »