Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3383)

Unified Diff: chrome/browser/sync/test/integration/typed_urls_helper.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/test/integration/autofill_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/typed_urls_helper.cc
diff --git a/chrome/browser/sync/test/integration/typed_urls_helper.cc b/chrome/browser/sync/test/integration/typed_urls_helper.cc
index 64ecd0c2637ac86286f512ef873ebb9021d65190..ea4b2bf6d38f00b72e7b72e4e56b48d5cf2d97a3 100644
--- a/chrome/browser/sync/test/integration/typed_urls_helper.cc
+++ b/chrome/browser/sync/test/integration/typed_urls_helper.cc
@@ -31,7 +31,10 @@ class FlushHistoryDBQueueTask : public HistoryDBTask {
}
virtual void DoneRunOnMainThread() OVERRIDE {}
+
private:
+ virtual ~FlushHistoryDBQueueTask() {}
+
base::WaitableEvent* wait_event_;
};
@@ -49,7 +52,10 @@ class GetTypedUrlsTask : public HistoryDBTask {
}
virtual void DoneRunOnMainThread() OVERRIDE {}
+
private:
+ virtual ~GetTypedUrlsTask() {}
+
history::URLRows* rows_;
base::WaitableEvent* wait_event_;
};
@@ -71,7 +77,10 @@ class GetUrlTask : public HistoryDBTask {
}
virtual void DoneRunOnMainThread() OVERRIDE {}
+
private:
+ virtual ~GetUrlTask() {}
+
GURL url_;
history::URLRow* row_;
base::WaitableEvent* wait_event_;
@@ -94,7 +103,10 @@ class GetVisitsTask : public HistoryDBTask {
}
virtual void DoneRunOnMainThread() OVERRIDE {}
+
private:
+ virtual ~GetVisitsTask() {}
+
history::URLID id_;
history::VisitVector* visits_;
base::WaitableEvent* wait_event_;
@@ -115,7 +127,10 @@ class RemoveVisitsTask : public HistoryDBTask {
}
virtual void DoneRunOnMainThread() OVERRIDE {}
+
private:
+ virtual ~RemoveVisitsTask() {}
+
const history::VisitVector& visits_;
base::WaitableEvent* wait_event_;
};
« no previous file with comments | « chrome/browser/sync/test/integration/autofill_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698