Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: chrome/browser/sync/glue/data_type_controller.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/data_type_controller.cc
diff --git a/chrome/browser/sync/glue/data_type_controller.cc b/chrome/browser/sync/glue/data_type_controller.cc
index 9014ece073505d048dc423f2c6edeb8520448256..0421298d8dc28fdf7396fc82c203b17e7841101c 100644
--- a/chrome/browser/sync/glue/data_type_controller.cc
+++ b/chrome/browser/sync/glue/data_type_controller.cc
@@ -13,6 +13,14 @@ bool DataTypeController::IsUnrecoverableResult(StartResult result) {
return (result == UNRECOVERABLE_ERROR);
}
+SyncError DataTypeController::CreateAndUploadError(
+ const tracked_objects::Location& location,
+ const std::string& message,
+ syncable::ModelType type) {
+ ChromeReportUnrecoverableError();
+ return SyncError(location, message, type);
+}
+
void DataTypeController::RecordUnrecoverableError(
const tracked_objects::Location& from_here,
const std::string& message) {
@@ -25,12 +33,4 @@ void DataTypeController::RecordUnrecoverableError(
ChromeReportUnrecoverableError();
}
-SyncError DataTypeController::CreateAndUploadError(
- const tracked_objects::Location& location,
- const std::string& message,
- syncable::ModelType type) {
- ChromeReportUnrecoverableError();
- return SyncError(location, message, type);
-}
-
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/data_type_controller.h ('k') | chrome/browser/sync/glue/data_type_controller_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698