Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
Reviewers:
Nico, Scott Byer
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, darin-cc_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

RefCounted types should not have public destructors, chrome/ edition BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133927

Patch Set 1 #

Total comments: 1

Patch Set 2 : Implementation fixes #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -388 lines) Patch
M chrome/common/extensions/extension_permission_set.h View 1 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 8 chunks +15 lines, -16 lines 4 comments Download
M chrome/common/json_pref_store.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/json_pref_store.cc View 1 4 chunks +42 lines, -41 lines 2 comments Download
M chrome/common/net/gaia/gaia_oauth_client.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/persistent_pref_store.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.h View 1 5 chunks +22 lines, -20 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 5 chunks +23 lines, -24 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/job_status_updater.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/service/cloud_print/job_status_updater.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/service/cloud_print/print_system.h View 1 7 chunks +17 lines, -7 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 6 chunks +15 lines, -7 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 1 5 chunks +30 lines, -21 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 8 chunks +212 lines, -213 lines 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.cc View 1 3 chunks +15 lines, -16 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/thread_observer_helper.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ryan Sleevi
dmaclach: PTAL
8 years, 8 months ago (2012-04-13 09:44:34 UTC) #1
dmac
On 2012/04/13 09:44:34, Ryan Sleevi wrote: > dmaclach: PTAL Hey Ryan... I'm no longer on ...
8 years, 8 months ago (2012-04-16 12:43:06 UTC) #2
Ryan Sleevi
-dmac +sbyer
8 years, 8 months ago (2012-04-16 16:56:11 UTC) #3
Scott Byer
LGTM w/ nit. You'll also need reviewers for chrome/test and chrome/common (I looked, but I'm ...
8 years, 8 months ago (2012-04-16 17:14:39 UTC) #4
Scott Byer
http://codereview.chromium.org/10065040/diff/1/chrome/service/cloud_print/cloud_print_proxy_backend.cc File chrome/service/cloud_print/cloud_print_proxy_backend.cc (right): http://codereview.chromium.org/10065040/diff/1/chrome/service/cloud_print/cloud_print_proxy_backend.cc#newcode97 chrome/service/cloud_print/cloud_print_proxy_backend.cc:97: nit: extra line
8 years, 8 months ago (2012-04-16 17:14:48 UTC) #5
Ryan Sleevi
Nico: You mind stamping chrome/common and chrome/test, since you're listed in chrome/OWNERS ?
8 years, 8 months ago (2012-04-25 06:52:53 UTC) #6
Nico
http://codereview.chromium.org/10065040/diff/11001/chrome/common/extensions/extension_permission_set.cc File chrome/common/extensions/extension_permission_set.cc (left): http://codereview.chromium.org/10065040/diff/11001/chrome/common/extensions/extension_permission_set.cc#oldcode482 chrome/common/extensions/extension_permission_set.cc:482: ExtensionPermissionSet::~ExtensionPermissionSet() {} Wasn't the consensus on that thread to ...
8 years, 8 months ago (2012-04-25 13:20:36 UTC) #7
Ryan Sleevi
http://codereview.chromium.org/10065040/diff/11001/chrome/common/extensions/extension_permission_set.cc File chrome/common/extensions/extension_permission_set.cc (left): http://codereview.chromium.org/10065040/diff/11001/chrome/common/extensions/extension_permission_set.cc#oldcode482 chrome/common/extensions/extension_permission_set.cc:482: ExtensionPermissionSet::~ExtensionPermissionSet() {} On 2012/04/25 13:20:37, Nico wrote: > Wasn't ...
8 years, 8 months ago (2012-04-25 15:13:58 UTC) #8
Nico
lgtm I'm with jar on the "moving code around for foolish consistency hurts way more ...
8 years, 8 months ago (2012-04-25 15:24:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10065040/11001
8 years, 8 months ago (2012-04-25 15:28:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10065040/11001
8 years, 8 months ago (2012-04-25 15:29:54 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 16:59:13 UTC) #12 
Change committed as 133927

Powered by Google App Engine
This is Rietveld 408576698