Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10430)

Unified Diff: chrome/service/cloud_print/cloud_print_auth.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_auth.h
diff --git a/chrome/service/cloud_print/cloud_print_auth.h b/chrome/service/cloud_print/cloud_print_auth.h
index 1fb3336ffa52033a6759751aed81e60ef9ccc9fc..783d113fe5321c02231293c6fba7c838fc2138b3 100644
--- a/chrome/service/cloud_print/cloud_print_auth.h
+++ b/chrome/service/cloud_print/cloud_print_auth.h
@@ -41,7 +41,6 @@ class CloudPrintAuth
const base::DictionaryValue* print_sys_settings,
const gaia::OAuthClientInfo& oauth_client_info,
const std::string& proxy_id);
- virtual ~CloudPrintAuth();
// Note:
//
@@ -83,6 +82,9 @@ class CloudPrintAuth
virtual std::string GetAuthHeader() OVERRIDE;
private:
+ friend class base::RefCountedThreadSafe<CloudPrintAuth>;
+ virtual ~CloudPrintAuth();
+
Client* client_;
gaia::OAuthClientInfo oauth_client_info_;
scoped_ptr<gaia::GaiaOAuthClient> oauth_client_;

Powered by Google App Engine
This is Rietveld 408576698