RefCounted types should not have public destructors, chrome/ remaining parts

chrome/service/cloud_print/printer_job_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
 #define CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
 #pragma once
 
 #include <list>
 #include <string>
@@ skipping 49 matching lines @@
 //                              |
 //                              |
 //                             Stop
 //               (If there are pending tasks go back to Start)
 
 class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,
                           public CloudPrintURLFetcherDelegate,
                           public JobStatusUpdaterDelegate,
                           public cloud_print::PrinterWatcherDelegate,
                           public cloud_print::JobSpoolerDelegate {
-  enum PrintJobError {
-    SUCCESS,
-    JOB_DOWNLOAD_FAILED,
-    INVALID_JOB_DATA,
-    PRINT_FAILED,
-  };
-  struct JobDetails {
-    JobDetails();
-    ~JobDetails();
-    void Clear();
-
-    std::string job_id_;
-    std::string job_title_;
-    std::string print_ticket_;
-    FilePath print_data_file_path_;
-    std::string print_data_mime_type_;
-    std::vector<std::string> tags_;
-  };
-
  public:
   class Delegate {
    public:
      // Notify delegate about authentication error.
      virtual void OnAuthError() = 0;
      // Notify delegate that printer has been deleted.
      virtual void OnPrinterDeleted(const std::string& printer_name) = 0;
 
    protected:
      virtual ~Delegate() {}
   };
 
   struct PrinterInfoFromCloud {
     std::string printer_id;
     std::string caps_hash;
     std::string tags_hash;
   };
 
   // Begin public interface
   PrinterJobHandler(const printing::PrinterBasicInfo& printer_info,
                     const PrinterInfoFromCloud& printer_info_from_server,
                     const GURL& cloud_print_server_url,
                     cloud_print::PrintSystem* print_system,
                     Delegate* delegate);
-  virtual ~PrinterJobHandler();
+
   bool Initialize();
+
   std::string GetPrinterName() const;
+
   // Requests a job check. |reason| is the reason for fetching the job. Used
   // for logging and diagnostc purposes.
   void CheckForJobs(const std::string& reason);
+
   // Shutdown everything (the process is exiting).
   void Shutdown();
+
   base::TimeTicks last_job_fetch_time() const { return last_job_fetch_time_; }
   // End public interface
 
   // Begin Delegate implementations
 
   // CloudPrintURLFetcher::Delegate implementation.
   virtual CloudPrintURLFetcher::ResponseAction HandleRawResponse(
       const content::URLFetcher* source,
       const GURL& url,
       const net::URLRequestStatus& status,
@@ skipping 24 matching lines @@
 
   // cloud_print::JobSpoolerDelegate implementation.
   // Called on print_thread_.
   virtual void OnJobSpoolSucceeded(
       const cloud_print::PlatformJobId& job_id) OVERRIDE;
   virtual void OnJobSpoolFailed() OVERRIDE;
 
   // End Delegate implementations
 
  private:
+  friend class base::RefCountedThreadSafe<PrinterJobHandler>;
+
+  enum PrintJobError {
+    SUCCESS,
+    JOB_DOWNLOAD_FAILED,
+    INVALID_JOB_DATA,
+    PRINT_FAILED,
+  };
+
   // Prototype for a JSON data handler.
   typedef CloudPrintURLFetcher::ResponseAction
       (PrinterJobHandler::*JSONDataHandler)(const content::URLFetcher* source,
                                             const GURL& url,
                                             base::DictionaryValue* json_data,
                                             bool succeeded);
   // Prototype for a data handler.
   typedef CloudPrintURLFetcher::ResponseAction
       (PrinterJobHandler::*DataHandler)(const content::URLFetcher* source,
                                         const GURL& url,
                                         const std::string& data);
+
+  struct JobDetails {
+    JobDetails();
+    ~JobDetails();
+    void Clear();
+
+    std::string job_id_;
+    std::string job_title_;
+    std::string print_ticket_;
+    FilePath print_data_file_path_;
+    std::string print_data_mime_type_;
+    std::vector<std::string> tags_;
+  };
+
+  virtual ~PrinterJobHandler();
+
   // Begin request handlers for each state in the state machine
   CloudPrintURLFetcher::ResponseAction HandlePrinterUpdateResponse(
       const content::URLFetcher* source,
       const GURL& url,
       base::DictionaryValue* json_data,
       bool succeeded);
 
   CloudPrintURLFetcher::ResponseAction HandleJobMetadataResponse(
       const content::URLFetcher* source,
       const GURL& url,
@@ skipping 26 matching lines @@
   // Start the state machine. Based on the flags set this could mean updating
   // printer information, deleting the printer from the server or looking for
   // new print jobs
   void Start();
 
   // End the state machine. If there are pending tasks, we will post a Start
   // again.
   void Stop();
 
   void StartPrinting();
-  void HandleServerError(const GURL& url);
   void Reset();
   void UpdateJobStatus(cloud_print::PrintJobStatus status, PrintJobError error);
 
   // Sets the next response handler to the specifed JSON data handler.
   void SetNextJSONHandler(JSONDataHandler handler);
   // Sets the next response handler to the specifed data handler.
   void SetNextDataHandler(DataHandler handler);
 
   void JobFailed(PrintJobError error);
   void JobSpooled(cloud_print::PlatformJobId local_job_id);
@@ skipping 62 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(PrinterJobHandler);
 };
 
 // This typedef is to workaround the issue with certain versions of
 // Visual Studio where it gets confused between multiple Delegate
 // classes and gives a C2500 error. (I saw this error on the try bots -
 // the workaround was not needed for my machine).
 typedef PrinterJobHandler::Delegate PrinterJobHandlerDelegate;
 
 #endif  // CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_