chrome/service/cloud_print/job_status_updater.h - Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/job_status_updater.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/json_pref_store.cc ('K') | « chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc ('k') | chrome/service/cloud_print/job_status_updater.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/job_status_updater.h

diff --git a/chrome/service/cloud_print/job_status_updater.h b/chrome/service/cloud_print/job_status_updater.h

index a6ad103fec205b1b4a5d5a3e12b46f968ac12b10..14009291488cdf97decf5ae500880b47604915c9 100644

--- a/chrome/service/cloud_print/job_status_updater.h

+++ b/chrome/service/cloud_print/job_status_updater.h

@@ -38,7 +38,6 @@ class JobStatusUpdater : public base::RefCountedThreadSafe<JobStatusUpdater>,

const GURL& cloud_print_server_url,

cloud_print::PrintSystem* print_system,

Delegate* delegate);

- virtual ~JobStatusUpdater();

// Checks the status of the local print job and sends an update.

void UpdateStatus();

@@ -54,6 +53,9 @@ class JobStatusUpdater : public base::RefCountedThreadSafe<JobStatusUpdater>,

virtual std::string GetAuthHeader() OVERRIDE;

private:

+ friend class base::RefCountedThreadSafe<JobStatusUpdater>;

+ virtual ~JobStatusUpdater();

std::string printer_name_;

std::string job_id_;

cloud_print::PlatformJobId local_job_id_;