RefCounted types should not have public destructors, chrome/ remaining parts

chrome/service/gaia/service_gaia_authenticator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/gaia/service_gaia_authenticator.h"
 
 #include "base/bind.h"
 #include "base/message_loop_proxy.h"
 #include "chrome/service/net/service_url_request_context.h"
 #include "chrome/service/service_process.h"
 #include "content/public/common/url_fetcher.h"
 #include "googleurl/src/gurl.h"
 
 ServiceGaiaAuthenticator::ServiceGaiaAuthenticator(
     const std::string& user_agent, const std::string& service_id,
     const std::string& gaia_url,
     base::MessageLoopProxy* io_message_loop_proxy)
         : gaia::GaiaAuthenticator(user_agent, service_id, gaia_url),
           http_post_completed_(false, false),
           io_message_loop_proxy_(io_message_loop_proxy),
           http_response_code_(0) {
 }
 
-ServiceGaiaAuthenticator::~ServiceGaiaAuthenticator() {
+// content::URLFetcherDelegate implementation
+void ServiceGaiaAuthenticator::OnURLFetchComplete(
+    const content::URLFetcher* source) {
+  DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
+  http_response_code_ = source->GetResponseCode();
+  source->GetResponseAsString(&response_data_);
+  delete source;
+  // Add an extra reference because we want http_post_completed_ to remain
+  // valid until after Signal() returns.
+  scoped_refptr<ServiceGaiaAuthenticator> keep_alive(this);
+  // Wake the blocked thread in Post.
+  http_post_completed_.Signal();
+  // WARNING: DONT DO ANYTHING AFTER THIS CALL! |this| may be deleted!
 }
 
 bool ServiceGaiaAuthenticator::Post(const GURL& url,
                                     const std::string& post_body,
                                     unsigned long* response_code,
                                     std::string* response_body) {
   DCHECK(url.SchemeIsSecure());
   DCHECK(io_message_loop_proxy_);
   io_message_loop_proxy_->PostTask(
       FROM_HERE,
@@ skipping 19 matching lines @@
     ret = 1;
   } else {
     ret = current_backoff_delay * 2;
   }
   if (ret > kMaxBackoffDelaySeconds) {
     ret = kMaxBackoffDelaySeconds;
   }
   return ret;
 }
 
+ServiceGaiaAuthenticator::~ServiceGaiaAuthenticator() {}
+
 void ServiceGaiaAuthenticator::DoPost(const GURL& post_url,
                                       const std::string& post_body) {
   DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
   content::URLFetcher* request = content::URLFetcher::Create(
       post_url, content::URLFetcher::POST, this);
   request->SetRequestContext(
       g_service_process->GetServiceURLRequestContextGetter());
   request->SetUploadData("application/x-www-form-urlencoded", post_body);
   request->Start();
 }
-
-// content::URLFetcherDelegate implementation
-void ServiceGaiaAuthenticator::OnURLFetchComplete(
-    const content::URLFetcher* source) {
-  DCHECK(io_message_loop_proxy_->BelongsToCurrentThread());
-  http_response_code_ = source->GetResponseCode();
-  source->GetResponseAsString(&response_data_);
-  delete source;
-  // Add an extra reference because we want http_post_completed_ to remain
-  // valid until after Signal() returns.
-  scoped_refptr<ServiceGaiaAuthenticator> keep_alive(this);
-  // Wake the blocked thread in Post.
-  http_post_completed_.Signal();
-  // WARNING: DONT DO ANYTHING AFTER THIS CALL! |this| may be deleted!
-}