Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3739)

Unified Diff: chrome/service/cloud_print/print_system_win.cc

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/print_system_win.cc
diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc
index b9d5c528be9a5851146e0b7768c0505ba82db79f..7ae902c48b65278137fcf9f0ec206c258a26b380 100644
--- a/chrome/service/cloud_print/print_system_win.cc
+++ b/chrome/service/cloud_print/print_system_win.cc
@@ -290,6 +290,9 @@ class PrintSystemWin : public PrintSystem {
virtual void OnPrinterChanged() OVERRIDE {}
virtual void OnJobChanged() OVERRIDE {}
+ protected:
+ virtual ~PrintServerWatcherWin() {}
+
private:
PrintSystem::PrintServerWatcher::Delegate* delegate_;
PrintSystemWatcherWin watcher_;
@@ -338,6 +341,9 @@ class PrintSystemWin : public PrintSystem {
delegate_->OnJobChanged();
}
+ protected:
+ virtual ~PrinterWatcherWin() {}
+
private:
std::string printer_name_;
PrintSystem::PrinterWatcher::Delegate* delegate_;
@@ -368,6 +374,9 @@ class PrintSystemWin : public PrintSystem {
delegate);
}
+ protected:
+ virtual ~JobSpoolerWin() {}
+
private:
// We use a Core class because we want a separate RefCountedThreadSafe
// implementation for ServiceUtilityProcessHost::Client.

Powered by Google App Engine
This is Rietveld 408576698