RefCounted types should not have public destructors, chrome/ remaining parts

chrome/service/cloud_print/cloud_print_connector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/cloud_print/cloud_print_connector.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/md5.h"
 #include "base/rand_util.h"
@@ skipping 16 matching lines @@
   : client_(client),
     proxy_id_(proxy_id),
     cloud_print_server_url_(cloud_print_server_url),
     next_response_handler_(NULL) {
   if (print_system_settings) {
     // It is possible to have no print settings specified.
     print_system_settings_.reset(print_system_settings->DeepCopy());
   }
 }
 
-CloudPrintConnector::~CloudPrintConnector() {
-}
-
 bool CloudPrintConnector::Start() {
   DCHECK(!print_system_.get());
   VLOG(1) << "CP_CONNECTOR: Starting connector, id: " << proxy_id_;
 
   pending_tasks_.clear();
 
   print_system_ =
       cloud_print::PrintSystem::CreateInstance(print_system_settings_.get());
   if (!print_system_.get()) {
     NOTREACHED();
@@ skipping 88 matching lines @@
     const GURL& url,
     DictionaryValue* json_data,
     bool succeeded) {
   if (!IsRunning())  // Orphant response. Connector has been stopped already.
     return CloudPrintURLFetcher::STOP_PROCESSING;
 
   DCHECK(next_response_handler_);
   return (this->*next_response_handler_)(source, url, json_data, succeeded);
 }
 
+CloudPrintURLFetcher::ResponseAction CloudPrintConnector::OnRequestAuthError() {
+  OnAuthError();
+  return CloudPrintURLFetcher::STOP_PROCESSING;
+}
+
+std::string CloudPrintConnector::GetAuthHeader() {
+  return CloudPrintHelpers::GetCloudPrintAuthHeader();
+}
+
+CloudPrintConnector::~CloudPrintConnector() {}
+
 CloudPrintURLFetcher::ResponseAction
 CloudPrintConnector::HandlePrinterListResponse(
     const content::URLFetcher* source,
     const GURL& url,
     DictionaryValue* json_data,
     bool succeeded) {
   DCHECK(succeeded);
   if (!succeeded)
     return CloudPrintURLFetcher::RETRY_REQUEST;
 
@@ skipping 81 matching lines @@
       DictionaryValue* printer_data = NULL;
       if (printer_list->GetDictionary(0, &printer_data))
         InitJobHandlerForPrinter(printer_data);
     }
   }
   ContinuePendingTaskProcessing();  // Continue processing background tasks.
   return CloudPrintURLFetcher::STOP_PROCESSING;
 }
 
 
-CloudPrintURLFetcher::ResponseAction CloudPrintConnector::OnRequestAuthError() {
-  OnAuthError();
-  return CloudPrintURLFetcher::STOP_PROCESSING;
-}
-
-std::string CloudPrintConnector::GetAuthHeader() {
-  return CloudPrintHelpers::GetCloudPrintAuthHeader();
-}
-
 void CloudPrintConnector::StartGetRequest(const GURL& url,
                                           int max_retries,
                                           ResponseHandler handler) {
   next_response_handler_ = handler;
   request_ = new CloudPrintURLFetcher;
   request_->StartGetRequest(url, this, max_retries, std::string());
 }
 
 void CloudPrintConnector::StartPostRequest(const GURL& url,
                                            int max_retries,
@@ skipping 134 matching lines @@
       OnPrinterRegister(task.printer_info);
       break;
     case PENDING_PRINTER_DELETE :
       OnPrinterDelete(task.printer_id);
       break;
     default:
       NOTREACHED();
   }
 }
 
+void CloudPrintConnector::ContinuePendingTaskProcessing() {
+  if (pending_tasks_.size() == 0)
+    return;  // No pending tasks.
+
+  // Delete current task and repost if we have more task available.
+  pending_tasks_.pop_front();
+  if (pending_tasks_.size() != 0) {
+    MessageLoop::current()->PostTask(
+        FROM_HERE, base::Bind(&CloudPrintConnector::ProcessPendingTask, this));
+  }
+}
+
 void CloudPrintConnector::OnPrintersAvailable() {
   GURL printer_list_url =
       CloudPrintHelpers::GetUrlForPrinterList(cloud_print_server_url_,
                                               proxy_id_);
   StartGetRequest(printer_list_url,
                   kCloudPrintRegisterMaxRetryCount,
                   &CloudPrintConnector::HandlePrinterListResponse);
 }
 
 void CloudPrintConnector::OnPrinterRegister(
@@ skipping 26 matching lines @@
   // TODO(gene): We probably should not try indefinitely here. Just once or
   // twice should be enough.
   // Bug: http://code.google.com/p/chromium/issues/detail?id=101850
   GURL url = CloudPrintHelpers::GetUrlForPrinterDelete(cloud_print_server_url_,
                                                        printer_id);
   StartGetRequest(url,
                   kCloudPrintAPIMaxRetryCount,
                   &CloudPrintConnector::HandlePrinterDeleteResponse);
 }
 
-void CloudPrintConnector::ContinuePendingTaskProcessing() {
-  if (pending_tasks_.size() == 0)
-    return;  // No pending tasks.
-
-  // Delete current task and repost if we have more task available.
-  pending_tasks_.pop_front();
-  if (pending_tasks_.size() != 0) {
-    MessageLoop::current()->PostTask(
-        FROM_HERE, base::Bind(&CloudPrintConnector::ProcessPendingTask, this));
-  }
-}
-
 void CloudPrintConnector::OnReceivePrinterCaps(
     bool succeeded,
     const std::string& printer_name,
     const printing::PrinterCapsAndDefaults& caps_and_defaults) {
   if (!IsRunning())
     return;  // Orphant call.
   DCHECK(pending_tasks_.size() > 0 &&
          pending_tasks_.front().type == PENDING_PRINTER_REGISTER);
 
   if (!succeeded) {
@@ skipping 56 matching lines @@
                    mime_type,
                    post_data,
                    &CloudPrintConnector::HandleRegisterPrinterResponse);
 }
 
 bool CloudPrintConnector::IsSamePrinter(const std::string& name1,
                                         const std::string& name2) const {
   return (0 == base::strcasecmp(name1.c_str(), name2.c_str()));
 }