RefCounted types should not have public destructors, chrome/ remaining parts

chrome/common/extensions/extension_permission_set.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_PERMISSION_SET_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_PERMISSION_SET_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 178 matching lines @@
   // Returns true if this permission can be added and removed via the
   // optional permissions extension API.
   bool supports_optional() const {
     return (flags_ & kFlagCannotBeOptional) == 0;
   }
 
  private:
   // Instances should only be constructed from within ExtensionPermissionsInfo.
   friend class ExtensionPermissionsInfo;
 
-  // Register ALL the permissions!
-  static void RegisterAllPermissions(ExtensionPermissionsInfo* info);
-
   explicit ExtensionAPIPermission(
       ID id,
       const char* name,
       int l10n_message_id,
       ExtensionPermissionMessage::ID message_id,
       int flags);
 
+  // Register ALL the permissions!
+  static void RegisterAllPermissions(ExtensionPermissionsInfo* info);
+
   ID id_;
   const char* name_;
   int flags_;
   int l10n_message_id_;
   ExtensionPermissionMessage::ID message_id_;
 };
 
 typedef std::set<ExtensionAPIPermission::ID> ExtensionAPIPermissionSet;
 
 // Singleton that holds the extension permission instances and provides static
@@ skipping 81 matching lines @@
 
   // Creates a new permission set that has oauth scopes in it.
   ExtensionPermissionSet(const ExtensionAPIPermissionSet& apis,
                          const URLPatternSet& explicit_hosts,
                          const URLPatternSet& scriptable_hosts,
                          const ExtensionOAuth2Scopes& scopes);
 
   // Creates a new permission set containing only oauth scopes.
   explicit ExtensionPermissionSet(const ExtensionOAuth2Scopes& scopes);
 
-  ~ExtensionPermissionSet();
-
   // Creates a new permission set equal to |set1| - |set2|, passing ownership of
   // the new set to the caller.
   static ExtensionPermissionSet* CreateDifference(
       const ExtensionPermissionSet* set1, const ExtensionPermissionSet* set2);
 
   // Creates a new permission set equal to the intersection of |set1| and
   // |set2|, passing ownership of the new set to the caller.
   static ExtensionPermissionSet* CreateIntersection(
       const ExtensionPermissionSet* set1, const ExtensionPermissionSet* set2);
 
@@ skipping 71 matching lines @@
 
   const URLPatternSet& explicit_hosts() const { return explicit_hosts_; }
 
   const URLPatternSet& scriptable_hosts() const { return scriptable_hosts_; }
 
   const ExtensionOAuth2Scopes& scopes() const { return scopes_; }
 
  private:
   FRIEND_TEST_ALL_PREFIXES(ExtensionPermissionsTest,
                            HasLessHostPrivilegesThan);
+  friend class base::RefCountedThreadSafe<ExtensionPermissionSet>;
 
-  friend class base::RefCountedThreadSafe<ExtensionPermissionSet>;
+  ~ExtensionPermissionSet();
 
   static std::set<std::string> GetDistinctHosts(
       const URLPatternSet& host_patterns,
       bool include_rcd,
       bool exclude_file_scheme);
 
   // Initializes the set based on |extension|'s manifest data.
   void InitImplicitExtensionPermissions(const Extension* extension);
 
   // Initializes the effective host permission based on the data in this set.
@@ skipping 29 matching lines @@
 
   // The list of hosts this effectively grants access to.
   URLPatternSet effective_hosts_;
 
   // A set of oauth2 scopes that are used by the identity API to create OAuth2
   // tokens for accessing the Google Account of the signed-in sync account.
   ExtensionOAuth2Scopes scopes_;
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_PERMISSION_SET_H_