RefCounted types should not have public destructors, chrome/ remaining parts

chrome/service/cloud_print/cloud_print_connector.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_CONNECTOR_H_
 #define CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_CONNECTOR_H_
 #pragma once
 
 #include <list>
 #include <map>
@@ skipping 21 matching lines @@
    public:
     virtual void OnAuthFailed() = 0;
    protected:
      virtual ~Client() {}
   };
 
   CloudPrintConnector(Client* client,
                       const std::string& proxy_id,
                       const GURL& cloud_print_server_url,
                       const DictionaryValue* print_system_settings);
-  virtual ~CloudPrintConnector();
 
   bool Start();
   void Stop();
   bool IsRunning();
 
   // Register printer from the list.
   void RegisterPrinters(const printing::PrinterList& printers);
 
   // Check for jobs for specific printer. If printer id is empty
   // jobs will be checked for all available printers.
   void CheckForJobs(const std::string& reason, const std::string& printer_id);
 
   // cloud_print::PrintServerWatcherDelegate implementation
   virtual void OnPrinterAdded() OVERRIDE;
   // PrinterJobHandler::Delegate implementation
   virtual void OnPrinterDeleted(const std::string& printer_name) OVERRIDE;
   virtual void OnAuthError() OVERRIDE;
 
   // CloudPrintURLFetcher::Delegate implementation.
   virtual CloudPrintURLFetcher::ResponseAction HandleRawData(
       const content::URLFetcher* source,
       const GURL& url,
       const std::string& data) OVERRIDE;
-
   virtual CloudPrintURLFetcher::ResponseAction HandleJSONData(
       const content::URLFetcher* source,
       const GURL& url,
       base::DictionaryValue* json_data,
       bool succeeded) OVERRIDE;
   virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError() OVERRIDE;
   virtual std::string GetAuthHeader() OVERRIDE;
 
  private:
+  friend class base::RefCountedThreadSafe<CloudPrintConnector>;
+
   // Prototype for a response handler.
   typedef CloudPrintURLFetcher::ResponseAction
       (CloudPrintConnector::*ResponseHandler)(
           const content::URLFetcher* source,
           const GURL& url,
           DictionaryValue* json_data,
           bool succeeded);
 
+  enum PendingTaskType {
+    PENDING_PRINTERS_NONE,
+    PENDING_PRINTERS_AVAILABLE,
+    PENDING_PRINTER_REGISTER,
+    PENDING_PRINTER_DELETE
+  };
+
+  // TODO(jhawkins): This name conflicts with base::PendingTask.
+  struct PendingTask {
+    PendingTaskType type;
+    // Optional members, depending on type.
+    std::string printer_id;  // For pending delete.
+    printing::PrinterBasicInfo printer_info;  // For pending registration.
+
+    PendingTask() : type(PENDING_PRINTERS_NONE) {}
+    ~PendingTask() {}
+  };
+
+  virtual ~CloudPrintConnector();
+
   // Begin response handlers
   CloudPrintURLFetcher::ResponseAction HandlePrinterListResponse(
       const content::URLFetcher* source,
       const GURL& url,
       DictionaryValue* json_data,
       bool succeeded);
 
   CloudPrintURLFetcher::ResponseAction HandlePrinterDeleteResponse(
       const content::URLFetcher* source,
       const GURL& url,
@@ skipping 19 matching lines @@
 
   // Reports a diagnostic message to the server.
   void ReportUserMessage(const std::string& message_id,
                          const std::string& failure_message);
 
   bool RemovePrinterFromList(const std::string& printer_name,
                              printing::PrinterList* printer_list);
 
   void InitJobHandlerForPrinter(DictionaryValue* printer_data);
 
-  enum PendingTaskType {
-    PENDING_PRINTERS_NONE,
-    PENDING_PRINTERS_AVAILABLE,
-    PENDING_PRINTER_REGISTER,
-    PENDING_PRINTER_DELETE
-  };
-
-  // TODO(jhawkins): This name conflicts with base::PendingTask.
-  struct PendingTask {
-    PendingTaskType type;
-    // Optional members, depending on type.
-    std::string printer_id;  // For pending delete.
-    printing::PrinterBasicInfo printer_info;  // For pending registration.
-
-    PendingTask() : type(PENDING_PRINTERS_NONE) {}
-    ~PendingTask() {}
-  };
-
   void AddPendingAvailableTask();
   void AddPendingDeleteTask(const std::string& id);
   void AddPendingRegisterTask(const printing::PrinterBasicInfo& info);
   void AddPendingTask(const PendingTask& task);
   void ProcessPendingTask();
   void ContinuePendingTaskProcessing();
   void OnPrintersAvailable();
   void OnPrinterRegister(const printing::PrinterBasicInfo& info);
   void OnPrinterDelete(const std::string& name);
 
@@ skipping 28 matching lines @@
   // The CloudPrintURLFetcher instance for the current request.
   scoped_refptr<CloudPrintURLFetcher> request_;
   // The CloudPrintURLFetcher instance for the user message request.
   scoped_refptr<CloudPrintURLFetcher> user_message_request_;
 
   DISALLOW_COPY_AND_ASSIGN(CloudPrintConnector);
 };
 
 #endif  // CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_CONNECTOR_H_