Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/test/base/ui_test_utils.cc

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/ui_test_utils.h" 5 #include "chrome/test/base/ui_test_utils.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #endif 9 #endif
10 10
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 202
203 virtual void FirstObjectAdded() { 203 virtual void FirstObjectAdded() {
204 AddRef(); 204 AddRef();
205 } 205 }
206 206
207 virtual void LastObjectRemoved() { 207 virtual void LastObjectRemoved() {
208 Release(); 208 Release();
209 } 209 }
210 210
211 private: 211 private:
212 friend class base::RefCounted<InProcessJavaScriptExecutionController>;
213 virtual ~InProcessJavaScriptExecutionController() {}
214
212 // Weak pointer to the associated RenderViewHost. 215 // Weak pointer to the associated RenderViewHost.
213 RenderViewHost* render_view_host_; 216 RenderViewHost* render_view_host_;
214 }; 217 };
215 218
216 // Specifying a prototype so that we can add the WARN_UNUSED_RESULT attribute. 219 // Specifying a prototype so that we can add the WARN_UNUSED_RESULT attribute.
217 bool ExecuteJavaScriptHelper(RenderViewHost* render_view_host, 220 bool ExecuteJavaScriptHelper(RenderViewHost* render_view_host,
218 const std::wstring& frame_xpath, 221 const std::wstring& frame_xpath,
219 const std::wstring& original_script, 222 const std::wstring& original_script,
220 scoped_ptr<Value>* result) WARN_UNUSED_RESULT; 223 scoped_ptr<Value>* result) WARN_UNUSED_RESULT;
221 224
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
1193 int state, 1196 int state,
1194 const base::Closure& followup) { 1197 const base::Closure& followup) {
1195 if (!followup.is_null()) 1198 if (!followup.is_null())
1196 ui_controls::SendMouseEventsNotifyWhenDone(button, state, followup); 1199 ui_controls::SendMouseEventsNotifyWhenDone(button, state, followup);
1197 else 1200 else
1198 ui_controls::SendMouseEvents(button, state); 1201 ui_controls::SendMouseEvents(button, state);
1199 } 1202 }
1200 1203
1201 } // namespace internal 1204 } // namespace internal
1202 } // namespace ui_test_utils 1205 } // namespace ui_test_utils
OLDNEW
« chrome/common/json_pref_store.cc ('K') | « chrome/test/base/thread_observer_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698