Clean password_manager::ui::State

Clean password_manager::ui::State.

The goal is to get rid of states "I'm opening the bubble now" as it should be an implementation detail of ManagePasswordsUIController.
For bubbles, which can be opened both automatically and later on user interaction, there should be exactly one state (like PENDING_PASSWORD_STATE).
For one-time automatic bubble there are two states. One is while the bubble is visible (e.g. CONFIRMATION_STATE). The second one is after it was closed (e.g. MANAGE_STATE).

BUG=400674
TBR=sky@chromium.org

Committed: https://crrev.com/ce64ac53deb73da655bb2c21f02c722835ee3bab
Cr-Commit-Position: refs/heads/master@{#316547}

[vasilii, 2015-02-16 11:01:17]

vasilii@chromium.org changed reviewers:
+ mkwst@chromium.org

[vasilii, 2015-02-16 11:03:44]

Hi Mike,

please review the CL.

[Mike West, 2015-02-16 11:45:34]

The bots are pretty sad. :(

I think the direction is fine, as it certainly clears up the external interface.
I'm not convinced that the AutoReset logic is correct, but once the bots are
happy, I think I'll be happy too.

https://codereview.chromium.org/928753003/diff/40001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/manage_passwords_bubble_model.cc (right):

https://codereview.chromium.org/928753003/diff/40001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:201:
ManagePasswordsUIController::FromWebContents(web_contents())
Does `::FromWebContents()` not return `nullptr` in this case already?

[vasilii, 2015-02-16 11:51:44]

I'm working on making everybody happy.

https://codereview.chromium.org/928753003/diff/40001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/manage_passwords_bubble_model.cc (right):

https://codereview.chromium.org/928753003/diff/40001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:201:
ManagePasswordsUIController::FromWebContents(web_contents())
On 2015/02/16 11:45:33, Mike West wrote:
> Does `::FromWebContents()` not return `nullptr` in this case already?

It returns "null pointer exception" via go/crash instead.

[vasilii, 2015-02-16 13:23:52]

Patchset #2 (id:20001) has been deleted

[vasilii, 2015-02-16 13:24:29]

Patchset #1 (id:1) has been deleted

[vasilii, 2015-02-16 13:27:29]

vasilii@chromium.org changed reviewers:
+ playmobil@chromium.org

[vasilii, 2015-02-16 13:28:05]

vasilii@chromium.org changed reviewers:
+ jeremy@chromium.org
- playmobil@chromium.org

[vasilii, 2015-02-16 13:29:14]

Hi Jeremy,

could you review chrome/browser/ui/cocoa?

Mike, I expect the tests to turn green.

[Mike West, 2015-02-16 13:30:11]

LGTM if the bots are green.

[vasilii, 2015-02-16 14:00:10]

New patchsets have been uploaded after l-g-t-m from mkwst@chromium.org

[vasilii, 2015-02-16 14:00:52]

On 2015/02/16 13:30:11, Mike West wrote:
> LGTM if the bots are green.

Thanks, the bots are green.

[vasilii, 2015-02-16 18:06:28]

vasilii@chromium.org changed reviewers:
+ asvitkine@chromium.org

[vasilii, 2015-02-16 18:06:29]

Alexei, please review chrome/browser/ui/cocoa

[Alexei Svitkine (slow), 2015-02-17 00:50:50]

LGTM, but please associate this with a crbug via BUG= in the CL description,
since this is a non-trivial change.

[vasilii, 2015-02-17 09:10:55]

vasilii@chromium.org changed reviewers:
- jeremy@chromium.org

[vasilii, 2015-02-17 09:12:49]

I'm TBRing sky@ for the trivial change in chrome/browser/ui/browser_commands.cc

[vasilii, 2015-02-17 09:13:40]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2015-02-17 09:14:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/928753003/80001

[commit-bot: I haz the power, 2015-02-17 09:30:53]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-02-17 09:31:24]

Patchset 3 (id:??) landed as
https://crrev.com/ce64ac53deb73da655bb2c21f02c722835ee3bab
Cr-Commit-Position: refs/heads/master@{#316547}