chrome/browser/ui/browser_commands.cc - Issue 928753003: Clean password_manager::ui::State

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index 589124265322206b98f49b4602e5ac725a1d018e..06da9b87d2adbc23ce77c27d10b276b4af13e610 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -818,9 +818,8 @@ void ManagePasswordsForPage(Browser* browser) {

browser->tab_strip_model()->GetActiveWebContents();

ManagePasswordsUIController* controller =

ManagePasswordsUIController::FromWebContents(web_contents);

- TabDialogs::FromWebContents(web_contents)

- ->ShowManagePasswordsBubble(

- !password_manager::ui::IsAutomaticDisplayState(controller->state()));

+ TabDialogs::FromWebContents(web_contents)->ShowManagePasswordsBubble(

+ !controller->IsAutomaticallyOpeningBubble());

}

#if defined(OS_WIN)

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm » ('j') | no next file with comments »