chrome/browser/ui/views/passwords/manage_password_items_view.cc - Issue 928753003: Clean password_manager::ui::State

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_password_items_view.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/passwords/manage_password_items_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_password_items_view.cc b/chrome/browser/ui/views/passwords/manage_password_items_view.cc

index 55b46ace0b1235baad65306b6f349cc48f6f4fdb..dc72fc264b2a63f62b5e90f3d684f0a8aa4be398 100644

--- a/chrome/browser/ui/views/passwords/manage_password_items_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_password_items_view.cc

@@ -147,7 +147,7 @@ void ManagePasswordItemsView::PasswordFormRow::AddCredentialsRow(

views::GridLayout* layout) {

ResetControls();

int column_set_id =

- password_manager::ui::IsPendingState(host_->model_->state())

+ host_->model_->state() == password_manager::ui::PENDING_PASSWORD_STATE

? TWO_COLUMN_SET

: THREE_COLUMN_SET;

BuildColumnSetIfNeeded(layout, column_set_id);

@@ -248,7 +248,7 @@ void ManagePasswordItemsView::NotifyPasswordFormStatusChanged(

}

void ManagePasswordItemsView::Refresh() {

- DCHECK(!password_manager::ui::IsPendingState(model_->state()));

+ DCHECK_NE(password_manager::ui::PENDING_PASSWORD_STATE, model_->state());

RemoveAllChildViews(true);

AddRows();

}