Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2981)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index a158ec2cbac4052f3a8734c66069e104c60ab519..eea0fb7d3e92d27b96f6c0ecd2ab57faf6408918 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -960,7 +960,7 @@ void ManagePasswordsBubbleView::Close() {
void ManagePasswordsBubbleView::Refresh() {
RemoveAllChildViews(true);
initially_focused_view_ = NULL;
- if (password_manager::ui::IsPendingState(model()->state())) {
+ if (model()->state() == password_manager::ui::PENDING_PASSWORD_STATE) {
if (model()->never_save_passwords())
AddChildView(new ConfirmNeverView(this));
else
@@ -971,7 +971,8 @@ void ManagePasswordsBubbleView::Refresh() {
AddChildView(new BlacklistedView(this));
} else if (model()->state() == password_manager::ui::CONFIRMATION_STATE) {
AddChildView(new SaveConfirmationView(this));
- } else if (password_manager::ui::IsCredentialsState(model()->state())) {
+ } else if (model()->state() ==
+ password_manager::ui::CREDENTIAL_REQUEST_STATE) {
AddChildView(new AccountChooserView(this));
} else {
AddChildView(new ManageView(this));

Powered by Google App Engine
This is Rietveld 408576698