Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: components/password_manager/core/common/password_manager_ui.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/common/password_manager_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/common/password_manager_ui.cc
diff --git a/components/password_manager/core/common/password_manager_ui.cc b/components/password_manager/core/common/password_manager_ui.cc
index 67ec96b81e139757cd612823737b0db9a54e4b5c..d3a1a2aac325b83b71d5200fd3deb7d37d4baf57 100644
--- a/components/password_manager/core/common/password_manager_ui.cc
+++ b/components/password_manager/core/common/password_manager_ui.cc
@@ -9,46 +9,11 @@ namespace password_manager {
namespace ui {
-bool IsPendingState(State state) {
- return state == PENDING_PASSWORD_AND_BUBBLE_STATE ||
- state == PENDING_PASSWORD_STATE;
-}
-
bool IsAskSubmitURLState(State state) {
- return state == ASK_USER_REPORT_URL_STATE ||
- state == ASK_USER_REPORT_URL_BUBBLE_SHOWN_BEFORE_TRANSITION_STATE ||
+ return state == ASK_USER_REPORT_URL_BUBBLE_SHOWN_BEFORE_TRANSITION_STATE ||
state == ASK_USER_REPORT_URL_BUBBLE_SHOWN_STATE;
}
-bool IsCredentialsState(State state) {
- return (state == CREDENTIAL_REQUEST_STATE ||
- state == CREDENTIAL_REQUEST_AND_BUBBLE_STATE);
-}
-
-bool IsAutomaticDisplayState(State state) {
- return state == PENDING_PASSWORD_AND_BUBBLE_STATE ||
- state == ASK_USER_REPORT_URL_STATE ||
- state == CONFIRMATION_STATE ||
- state == CREDENTIAL_REQUEST_AND_BUBBLE_STATE;
-}
-
-State GetEndStateForAutomaticState(State state) {
- DCHECK(IsAutomaticDisplayState(state));
- switch (state) {
- case PENDING_PASSWORD_AND_BUBBLE_STATE:
- return PENDING_PASSWORD_STATE;
- case CONFIRMATION_STATE:
- return MANAGE_STATE;
- case CREDENTIAL_REQUEST_AND_BUBBLE_STATE:
- return CREDENTIAL_REQUEST_STATE;
- case ASK_USER_REPORT_URL_STATE:
- return ASK_USER_REPORT_URL_BUBBLE_SHOWN_BEFORE_TRANSITION_STATE;
- default:
- NOTREACHED();
- return INACTIVE_STATE;
- }
-}
-
} // namespace ui
} // namespace password_manager
« no previous file with comments | « components/password_manager/core/common/password_manager_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698