chrome/browser/ui/passwords/manage_passwords_icon.cc - Issue 928753003: Clean password_manager::ui::State

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_icon.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_icon.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_icon.cc b/chrome/browser/ui/passwords/manage_passwords_icon.cc

index 5a12917569c6274ae2a45ae4fa0d4e987a567b78..cbe2855e812976e1ffaeaa06f7c5874061e33c89 100644

--- a/chrome/browser/ui/passwords/manage_passwords_icon.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_icon.cc

@@ -50,7 +50,7 @@ void ManagePasswordsIcon::UpdateIDs() {

if (state() == password_manager::ui::BLACKLIST_STATE)

icon_id_ = active() ? IDR_SAVE_PASSWORD_DISABLED_ACTIVE

: IDR_SAVE_PASSWORD_DISABLED_INACTIVE;

- else if (password_manager::ui::IsPendingState(state()))

+ else if (state() == password_manager::ui::PENDING_PASSWORD_STATE)

tooltip_text_id_ = IDS_PASSWORD_MANAGER_TOOLTIP_SAVE;

#endif

}