chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 928753003: Clean password_manager::ui::State

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | components/password_manager/core/common/password_manager_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index b67cfdb8454a56242105440268b5994e353db917..91a7d5b43ea24d13de73ceef26c771545a5858b7 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -116,7 +116,9 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, CommandControlsBubble) {

IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

CommandExecutionInManagingState) {

SetupManagingPasswords();

+ EXPECT_FALSE(ManagePasswordsBubbleView::IsShowing());

ExecuteManagePasswordsCommand();

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

scoped_ptr<base::HistogramSamples> samples(

GetSamples(kDisplayDispositionMetric));

@@ -136,6 +138,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

CommandExecutionInAutomaticState) {

// Open with pending password: automagical!

SetupPendingPassword();

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

// Bubble should not be focused by default.

EXPECT_FALSE(ManagePasswordsBubbleView::manage_password_bubble()->

@@ -162,9 +165,11 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

CommandExecutionInPendingState) {

// Open once with pending password: automagical!

SetupPendingPassword();

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

ManagePasswordsBubbleView::CloseBubble();

// This opening should be measured as manual.

ExecuteManagePasswordsCommand();

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

scoped_ptr<base::HistogramSamples> samples(

GetSamples(kDisplayDispositionMetric));

@@ -183,9 +188,11 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

CommandExecutionInAutomaticSaveState) {

SetupAutomaticPassword();

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

ManagePasswordsBubbleView::CloseBubble();

// Re-opening should count as manual.

ExecuteManagePasswordsCommand();

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

scoped_ptr<base::HistogramSamples> samples(

GetSamples(kDisplayDispositionMetric));