chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm - Issue 928753003: Clean password_manager::ui::State

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm

index 9e35a94afec29b96e4268a60ff82fcd0f7a119da..c6792cfad6ad22cbc45902e97392ce8673a59c1b 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm

@@ -292,7 +292,7 @@ base::string16 GetDisplayUsername(const autofill::PasswordForm& form) {

model_ = model;

position_ = position;

passwordForm_ = passwordForm;

- state_ = password_manager::ui::IsPendingState(model_->state())

+ state_ = model_->state() == password_manager::ui::PENDING_PASSWORD_STATE

? MANAGE_PASSWORD_ITEM_STATE_PENDING

: MANAGE_PASSWORD_ITEM_STATE_MANAGE;

[self updateContent];