Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: components/password_manager/core/common/password_manager_ui.h

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index bbde56bc98cabf3fc611df291c22ad76a8351721..eb1022523138e574c569a548323dd24aaf26d58e 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -16,12 +16,7 @@ enum State {
// The password manager has nothing to do with the current site.
INACTIVE_STATE,
- // A password has been typed in and submitted successfully. Now we need to
- // display an Omnibox icon, and pop up a bubble asking the user whether
- // they'd like to save the password.
- PENDING_PASSWORD_AND_BUBBLE_STATE,
-
- // A password is pending, but we don't need to pop up a bubble.
+ // A password is pending.
PENDING_PASSWORD_STATE,
// A password has been saved and we wish to display UI confirming the save
@@ -36,16 +31,9 @@ enum State {
// The icon needs to be visible, in the blacklisted state.
BLACKLIST_STATE,
- // The site has asked user to choose a credential. Now we need to display an
- // Omnibox icon, and pop up a bubble.
- CREDENTIAL_REQUEST_AND_BUBBLE_STATE,
-
- // Credentials are pending, but we don't need to pop up a bubble.
+ // The site has asked user to choose a credential.
CREDENTIAL_REQUEST_STATE,
- // Password manager failed to detect the form, so bubble should be pop upped.
- ASK_USER_REPORT_URL_STATE,
-
// Password manager failed to detect the form, bubble should outlive next
// navigation.
ASK_USER_REPORT_URL_BUBBLE_SHOWN_BEFORE_TRANSITION_STATE,
@@ -63,22 +51,8 @@ enum PasswordItemPosition {
SUBSEQUENT_ITEM,
};
-// Returns true if |state| represents a pending password.
-bool IsPendingState(State state);
-
-// Returns true if |state| represents a pending credentials.
-bool IsCredentialsState(State state);
-
-// Returns true if this state show cause the bubble to be shown without user
-// interaction.
-bool IsAutomaticDisplayState(State state);
-
bool IsAskSubmitURLState(State state);
-// Returns the state that the bubble should be in after the automatic display
-// occurs.
-State GetEndStateForAutomaticState(State state);
-
} // namespace ui
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698