Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 920933002: fix for uniform view matrix being uploaded but not used (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gp_cleanup_1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for uniform view matrix being uploaded but not used As discussed, I'll follow this up by removing localmatrix/uniform view matrix from the base classe BUG=skia: Committed: https://skia.googlesource.com/skia/+/dd2198701b0ec9da61ecf73418cad03642d715e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -93 lines) Patch
M src/effects/SkColorCubeFilter.cpp View 4 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M src/gpu/GrGeometryProcessor.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -15 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 4 chunks +7 lines, -16 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +3 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
joshualitt
5 years, 10 months ago (2015-02-12 21:43:32 UTC) #3
bsalomon
lgtm
5 years, 10 months ago (2015-02-12 21:50:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920933002/1
5 years, 10 months ago (2015-02-12 22:32:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 22:48:46 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd2198701b0ec9da61ecf73418cad03642d715e7

Powered by Google App Engine
This is Rietveld 408576698