src/gpu/GrOvalRenderer.cpp - Issue 920933002: fix for uniform view matrix being uploaded but not used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrOvalRenderer.cpp

Issue 920933002: fix for uniform view matrix being uploaded but not used (Closed) Base URL: https://skia.googlesource.com/skia.git@gp_cleanup_1

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/GrOvalRenderer.cpp

diff --git a/src/gpu/GrOvalRenderer.cpp b/src/gpu/GrOvalRenderer.cpp

index 0a18b49b0ccad9836971d09610b4dcb70d4a8fef..481501f1299df97eb301cb9056d26c807396f769 100644

--- a/src/gpu/GrOvalRenderer.cpp

+++ b/src/gpu/GrOvalRenderer.cpp

@@ -105,12 +105,8 @@ public:

this->setupColorPassThrough(pb, local.fInputColorType, args.fOutputColor, NULL,

&fColorUniform);

- // setup uniform viewMatrix

- this->addUniformViewMatrix(pb);

// Setup position

- SetupPosition(vsBuilder, gpArgs, ce.inPosition()->fName,

- ce.viewMatrix(), this->uViewM());

+ this->setupPosition(pb, gpArgs, ce.inPosition()->fName, ce.viewMatrix());

// emit transforms

this->emitTransforms(args.fPB, gpArgs->fPositionVar, ce.inPosition()->fName,

@@ -288,12 +284,8 @@ public:

this->setupColorPassThrough(pb, local.fInputColorType, args.fOutputColor, NULL,

&fColorUniform);

- // setup uniform viewMatrix

- this->addUniformViewMatrix(pb);

// Setup position

- SetupPosition(vsBuilder, gpArgs, ee.inPosition()->fName,

- ee.viewMatrix(), this->uViewM());

+ this->setupPosition(pb, gpArgs, ee.inPosition()->fName, ee.viewMatrix());

// emit transforms

this->emitTransforms(args.fPB, gpArgs->fPositionVar, ee.inPosition()->fName,

@@ -493,12 +485,8 @@ public:

this->setupColorPassThrough(pb, local.fInputColorType, args.fOutputColor, NULL,

&fColorUniform);

- // setup uniform viewMatrix

- this->addUniformViewMatrix(pb);

// Setup position

- SetupPosition(vsBuilder, gpArgs, ee.inPosition()->fName,

- ee.viewMatrix(), this->uViewM());

+ this->setupPosition(pb, gpArgs, ee.inPosition()->fName, ee.viewMatrix());

// emit transforms

this->emitTransforms(args.fPB, gpArgs->fPositionVar, ee.inPosition()->fName,

« no previous file with comments | « src/gpu/GrGeometryProcessor.cpp ('k') | src/gpu/effects/GrBezierEffect.cpp » ('j') | no next file with comments »