Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, binji+watch_chromium.org, arv+watch_chromium.org, jdduke+watch_chromium.org, Sam Clegg, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, bruening+watch_chromium.org, tdresser+watch_chromium.org, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, kalyank, Dai Mikurube (NOT FULLTIME), telemetry-reviews_chromium.org, klundberg+watch_chromium.org, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Presubmit API is built into depot_tools. Not in gcl, which probably these days nobody working on Chromium uses. BUG=None R=maruel@chromium.org TBR=maruel@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/78bb92f45822e605c46d303b66a7bddc9706b9d3 Cr-Commit-Position: refs/heads/master@{#314039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -51 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ash/resources/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M base/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M build/ios/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/theme/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_dev_style/css_checker.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/activity_log_private/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M media/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
M testing/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/checkperms/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/crx_id/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/cygprofile/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/deep_memory_profiler/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/find_runtime_symbols/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_to_struct/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/linux/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/lsan/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/actions/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf_expectations/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/drmemory/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/resource_check/resource_scale_factors.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
tfarina
5 years, 10 months ago (2015-01-30 16:15:35 UTC) #1
Marc-Antoine Ruel (Google)
lgtm
5 years, 10 months ago (2015-01-30 17:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887033002/1
5 years, 10 months ago (2015-01-30 20:51:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39541)
5 years, 10 months ago (2015-01-30 21:35:18 UTC) #7
tfarina
TBRing...there is no real change here, just rewording docs.
5 years, 10 months ago (2015-01-30 23:29:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887033002/1
5 years, 10 months ago (2015-01-30 23:31:04 UTC) #10
Sam Clegg
native_client_sdk lgtm. thanks!
5 years, 10 months ago (2015-01-31 00:13:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39604)
5 years, 10 months ago (2015-01-31 00:16:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887033002/1
5 years, 10 months ago (2015-01-31 00:19:41 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-31 00:21:18 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 00:22:37 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/78bb92f45822e605c46d303b66a7bddc9706b9d3
Cr-Commit-Position: refs/heads/master@{#314039}

Powered by Google App Engine
This is Rietveld 408576698