Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: tools/valgrind/memcheck/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/valgrind/drmemory/PRESUBMIT.py ('k') | ui/events/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 6 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
7 for more details on the presubmit API built into gcl. 7 for more details on the presubmit API built into depot_tools.
8 """ 8 """
9 9
10 import re 10 import re
11 11
12 def CheckChange(input_api, output_api): 12 def CheckChange(input_api, output_api):
13 """Checks the memcheck suppressions files for bad data.""" 13 """Checks the memcheck suppressions files for bad data."""
14 sup_regex = re.compile('suppressions.*\.txt$') 14 sup_regex = re.compile('suppressions.*\.txt$')
15 suppressions = {} 15 suppressions = {}
16 errors = [] 16 errors = []
17 check_for_memcheck = False 17 check_for_memcheck = False
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 line_num)) 69 line_num))
70 if errors: 70 if errors:
71 return [output_api.PresubmitError('\n'.join(errors))] 71 return [output_api.PresubmitError('\n'.join(errors))]
72 return [] 72 return []
73 73
74 def CheckChangeOnUpload(input_api, output_api): 74 def CheckChangeOnUpload(input_api, output_api):
75 return CheckChange(input_api, output_api) 75 return CheckChange(input_api, output_api)
76 76
77 def CheckChangeOnCommit(input_api, output_api): 77 def CheckChangeOnCommit(input_api, output_api):
78 return CheckChange(input_api, output_api) 78 return CheckChange(input_api, output_api)
OLDNEW
« no previous file with comments | « tools/valgrind/drmemory/PRESUBMIT.py ('k') | ui/events/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698