Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: tools/metrics/actions/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/memory_inspector/PRESUBMIT.py ('k') | tools/metrics/histograms/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for actions.xml. 5 """Presubmit script for actions.xml.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl. 8 for more details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 def CheckChange(input_api, output_api): 12 def CheckChange(input_api, output_api):
13 """Checks that actions.xml is up to date and pretty-printed.""" 13 """Checks that actions.xml is up to date and pretty-printed."""
14 for f in input_api.AffectedTextFiles(): 14 for f in input_api.AffectedTextFiles():
15 p = f.AbsoluteLocalPath() 15 p = f.AbsoluteLocalPath()
16 if (input_api.basename(p) == 'actions.xml' 16 if (input_api.basename(p) == 'actions.xml'
17 and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()): 17 and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):
18 cwd = input_api.os_path.dirname(p) 18 cwd = input_api.os_path.dirname(p)
19 exit_code = input_api.subprocess.call( 19 exit_code = input_api.subprocess.call(
20 ['python', 'extract_actions.py', '--presubmit'], cwd=cwd) 20 ['python', 'extract_actions.py', '--presubmit'], cwd=cwd)
21 if exit_code != 0: 21 if exit_code != 0:
22 return [output_api.PresubmitError( 22 return [output_api.PresubmitError(
23 'actions.xml is not up to date or is not formatted correctly; ' 23 'actions.xml is not up to date or is not formatted correctly; '
24 'run extract_actions.py to fix')] 24 'run extract_actions.py to fix')]
25 return [] 25 return []
26 26
27 27
28 def CheckChangeOnUpload(input_api, output_api): 28 def CheckChangeOnUpload(input_api, output_api):
29 return CheckChange(input_api, output_api) 29 return CheckChange(input_api, output_api)
30 30
31 31
32 def CheckChangeOnCommit(input_api, output_api): 32 def CheckChangeOnCommit(input_api, output_api):
33 return CheckChange(input_api, output_api) 33 return CheckChange(input_api, output_api)
OLDNEW
« no previous file with comments | « tools/memory_inspector/PRESUBMIT.py ('k') | tools/metrics/histograms/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698