PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ash/resources/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for Chromium.	5 """Top-level presubmit script for Chromium.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

11	11

12 _EXCLUDED_PATHS = (	12 _EXCLUDED_PATHS = (

13 r"^breakpad[\\\/].*",	13 r"^breakpad[\\\/].*",

14 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py",	14 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py",

15 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py",	15 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py",

16 r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",	16 r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",

17 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*",	17 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*",

18 r"^skia[\\\/].*",	18 r"^skia[\\\/].*",

(...skipping 1675 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1694 if 'presubmit' in builder:	1694 if 'presubmit' in builder:

1695 builders[master].pop(builder)	1695 builders[master].pop(builder)

1696	1696

1697 # Match things like path/aura/file.cc and path/file_aura.cc.	1697 # Match things like path/aura/file.cc and path/file_aura.cc.

1698 # Same for chromeos.	1698 # Same for chromeos.

1699 if any(re.search(r'[\\\/_](aura\|chromeos)', f) for f in files):	1699 if any(re.search(r'[\\\/_](aura\|chromeos)', f) for f in files):

1700 tryserver_linux = builders.setdefault('tryserver.chromium.linux', {})	1700 tryserver_linux = builders.setdefault('tryserver.chromium.linux', {})

1701 tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']	1701 tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']

1702	1702

1703 return builders	1703 return builders

OLD	NEW