chrome/test/data/extensions/api_test/activity_log_private/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/activity_log_private/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/PRESUBMIT.py ('k') | content/test/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Run the Chrome WebUI presubmit scripts on our test javascript.	5 """Run the Chrome WebUI presubmit scripts on our test javascript.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl/git cl, and see	8 for more details about the presubmit API built into depot_tools, and see

9 http://www.chromium.org/developers/web-development-style-guide for the rules	9 http://www.chromium.org/developers/web-development-style-guide for the rules

10 we're checking against here.	10 we're checking against here.

11 """	11 """

12	12

13 import os	13 import os

14	14

15 def GetPathsToPrepend(input_api):	15 def GetPathsToPrepend(input_api):

16 web_dev_style_path = input_api.os_path.join(	16 web_dev_style_path = input_api.os_path.join(

17 input_api.change.RepositoryRoot(),	17 input_api.change.RepositoryRoot(),

18 'chrome',	18 'chrome',

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 def is_resource(maybe_resource):	53 def is_resource(maybe_resource):

54 return _html_css_js_resource(maybe_resource.AbsoluteLocalPath())	54 return _html_css_js_resource(maybe_resource.AbsoluteLocalPath())

55	55

56 from web_dev_style import js_checker	56 from web_dev_style import js_checker

57	57

58 results = []	58 results = []

59 results.extend(js_checker.JSChecker(	59 results.extend(js_checker.JSChecker(

60 input_api, output_api, file_filter=is_resource).RunChecks())	60 input_api, output_api, file_filter=is_resource).RunChecks())

61	61

62 return results	62 return results

OLD	NEW