tools/memory_inspector/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/memory_inspector/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/lsan/PRESUBMIT.py ('k') | tools/metrics/actions/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for memory_inspector.	5 """Top-level presubmit script for memory_inspector.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into depot_tools.

9 """	9 """

10	10

11	11

12 def _CommonChecks(input_api, output_api):	12 def _CommonChecks(input_api, output_api):

13 output = []	13 output = []

14 blacklist = [r'classification_rules.*']	14 blacklist = [r'classification_rules.*']

15 output.extend(input_api.canned_checks.RunPylint(	15 output.extend(input_api.canned_checks.RunPylint(

16 input_api, output_api, black_list=blacklist,	16 input_api, output_api, black_list=blacklist,

17 extra_paths_list=[	17 extra_paths_list=[

18 input_api.os_path.join(input_api.PresubmitLocalPath(), '..', '..',	18 input_api.os_path.join(input_api.PresubmitLocalPath(), '..', '..',

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75	75

76 def CheckChangeOnUpload(input_api, output_api):	76 def CheckChangeOnUpload(input_api, output_api):

77 results = []	77 results = []

78 results.extend(_CommonChecks(input_api, output_api))	78 results.extend(_CommonChecks(input_api, output_api))

79 results.extend(_CheckPrebuiltsAreUploaded(input_api, output_api))	79 results.extend(_CheckPrebuiltsAreUploaded(input_api, output_api))

80 return results	80 return results

81	81

82	82

83 def CheckChangeOnCommit(input_api, output_api):	83 def CheckChangeOnCommit(input_api, output_api):

84 return _CommonChecks(input_api, output_api)	84 return _CommonChecks(input_api, output_api)

OLD	NEW