chrome/browser/resources/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/web_dev_style/css_checker.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for HTML files in chrome/browser/resources.	5 """Presubmit script for HTML files in chrome/browser/resources.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

11 ACTION_XML_PATH = '../../../tools/metrics/actions/actions.xml'	11 ACTION_XML_PATH = '../../../tools/metrics/actions/actions.xml'

12	12

13 def CheckUserActionUpdate(input_api, output_api, action_xml_path):	13 def CheckUserActionUpdate(input_api, output_api, action_xml_path):

14 """Checks if any new user action has been added."""	14 """Checks if any new user action has been added."""

15 if any('actions.xml' == input_api.os_path.basename(f) for f in	15 if any('actions.xml' == input_api.os_path.basename(f) for f in

16 input_api.change.LocalPaths()):	16 input_api.change.LocalPaths()):

17 # If actions.xml is already included in the changelist, the PRESUBMIT	17 # If actions.xml is already included in the changelist, the PRESUBMIT

18 # for actions.xml will do a more complete presubmit check.	18 # for actions.xml will do a more complete presubmit check.

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86 return (match and	86 return (match and

87 any(input_api.re.search(type_re, match.group(i)) for i in (1, 3)))	87 any(input_api.re.search(type_re, match.group(i)) for i in (1, 3)))

88	88

89	89

90 def CheckChangeOnUpload(input_api, output_api):	90 def CheckChangeOnUpload(input_api, output_api):

91 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)	91 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)

92	92

93	93

94 def CheckChangeOnCommit(input_api, output_api):	94 def CheckChangeOnCommit(input_api, output_api):

95 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)	95 return CheckUserActionUpdate(input_api, output_api, ACTION_XML_PATH)

OLD	NEW