tools/perf/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for changes affecting tools/perf/.	5 """Presubmit script for changes affecting tools/perf/.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl (and git-cl).	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

11 import os	11 import os

12 import sys	12 import sys

13	13

14 PYLINT_BLACKLIST = []	14 PYLINT_BLACKLIST = []

15 PYLINT_DISABLED_WARNINGS = [	15 PYLINT_DISABLED_WARNINGS = [

16 'R0923', # Interface not implemented	16 'R0923', # Interface not implemented

17 'R0201', # Method could be a function	17 'R0201', # Method could be a function

18 'E1101', # Non-existent member is accessed.	18 'E1101', # Non-existent member is accessed.

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 def CheckChangeOnUpload(input_api, output_api):	52 def CheckChangeOnUpload(input_api, output_api):

53 report = []	53 report = []

54 report.extend(_CommonChecks(input_api, output_api))	54 report.extend(_CommonChecks(input_api, output_api))

55 return report	55 return report

56	56

57	57

58 def CheckChangeOnCommit(input_api, output_api):	58 def CheckChangeOnCommit(input_api, output_api):

59 report = []	59 report = []

60 report.extend(_CommonChecks(input_api, output_api))	60 report.extend(_CommonChecks(input_api, output_api))

61 return report	61 return report

OLD	NEW

« no previous file with comments | « tools/metrics/histograms/PRESUBMIT.py ('k') | tools/perf_expectations/PRESUBMIT.py » ('j') | no next file with comments »