build/android/PRESUBMIT.py - Issue 887033002: Cleanup: Presubmit API is built into depot_tools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/PRESUBMIT.py

Issue 887033002: Cleanup: Presubmit API is built into depot_tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/PRESUBMIT.py ('k') | build/ios/PRESUBMIT.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for android buildbot.	5 """Presubmit script for android buildbot.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into depot_tools.

9 """	9 """

10	10

11 _DELETIONS_ONLY_FILES = (	11 _DELETIONS_ONLY_FILES = (

12 'build/android/findbugs_filter/findbugs_known_bugs.txt',	12 'build/android/findbugs_filter/findbugs_known_bugs.txt',

13 )	13 )

14	14

15	15

16 def _CheckDeletionsOnlyFiles(input_api, output_api):	16 def _CheckDeletionsOnlyFiles(input_api, output_api):

17 """Check that a certain listed files only have deletions.	17 """Check that a certain listed files only have deletions.

18 """	18 """

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 # output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))	73 # output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))

74 return output	74 return output

75	75

76	76

77 def CheckChangeOnUpload(input_api, output_api):	77 def CheckChangeOnUpload(input_api, output_api):

78 return CommonChecks(input_api, output_api)	78 return CommonChecks(input_api, output_api)

79	79

80	80

81 def CheckChangeOnCommit(input_api, output_api):	81 def CheckChangeOnCommit(input_api, output_api):

82 return CommonChecks(input_api, output_api)	82 return CommonChecks(input_api, output_api)

OLD	NEW