Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, shishir+watch_chromium.org, dcheng, stuartmorgan+watch_chromium.org, arv+watch_chromium.org, aandrey+blink_chromium.org, tim+watch_chromium.org, vsevik, melevin+watch_chromium.org, pvalenzuela+watch_chromium.org, rlp+watch_chromium.org, kalyank, jianli, paulirish+reviews_chromium.org, pam+watch_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, David Black, estade+watch_chromium.org, wjia+watch_chromium.org, pfeldman, asanka, vandebo (ex-Chrome), donnd+watch_chromium.org, tburkard+watch_chromium.org, dougw+watch_chromium.org, noyau+watch_chromium.org, native-client-reviews_googlegroups.com, benjhayden+dwatch_chromium.org, jam, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, rouslan+spellwatch_chromium.org, nhiroki, asvitkine+watch_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, gavinp+prer_chromium.org, Lei Zhang, yurys, eroman, mmenke, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, peter+watch_chromium.org, yusukes+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, extensions-reviews_chromium.org, nona+watch_chromium.org, dzhioev+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, davidben+watch_chromium.org, maxbogue+watch_chromium.org, tommycli, Greg Billock, James Su, kinuko+fileapi, skanuj+watch_chromium.org, tzik, posciak+watch_chromium.org, mcasas+watch_chromium.org, ajwong+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, marja+watch_chromium.org, dbeam+watch-options_chromium.org, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, Dmitry Titov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers chrome/browser/* from f on. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/556c05027f6d983007890054b6a9303a2bd4a4a2 Cr-Commit-Position: refs/heads/master@{#309485}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1051 lines, -884 lines) Patch
M chrome/browser/fast_shutdown_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_internal_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/upgrade_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/upgrade_util_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/fullscreen_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google/chrome_google_url_tracker_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/profile_invalidation_provider_factory_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/invalidation/ticl_profile_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 13 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/jumplist_updater_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/lifetime/application_lifetime_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/locale_tests_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/install_from_dmg.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 10 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_perf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/media/encrypted_media_istypesupported_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/media/test_license_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/wv_test_license_server_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_permission_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_scan_result_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_scan_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_services_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/cookie_store_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 8 chunks +16 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_generation_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/plugins/chrome_content_browser_client_plugins_part.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugins_resource_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/chrome_browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 10 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/policy/policy_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefetch/prefetch_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_browsertest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_factory.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_info_snapshot_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/process_singleton_modal_dialog_lock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_posix.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/process_singleton_startup_lock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_list_desktop_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_list_desktop_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type_platform_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_extension_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/search/search_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/service_process/service_process_control_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_desktop_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_data_deleter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 7 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/tts_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/feedback_sender.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/spellchecker/feedback_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_registration_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backup_rollback_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/backup_rollback_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/startup_controller.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync/startup_controller_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_supervised_user_settings_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_wifi_credentials_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/browser_process_resource_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/keyboard_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 16 chunks +22 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_window_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller_unittest.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 10 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M chrome/browser/ui/location_bar/origin_chip_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/passwords/password_manager_presenter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/settings_window_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 10 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 34 chunks +38 lines, -34 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/sync_promo_ui_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_menu_button_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui_supervised_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 11 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 2 5 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816403003/40001
6 years ago (2014-12-22 22:46:50 UTC) #2
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-22 23:32:24 UTC) #3
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/556c05027f6d983007890054b6a9303a2bd4a4a2 Cr-Commit-Position: refs/heads/master@{#309485}
6 years ago (2014-12-22 23:33:16 UTC) #4
Lei Zhang
5 years, 11 months ago (2015-01-05 20:23:37 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698