chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc - Issue 816403003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/session_crashed_bubble_view.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

index 9f1b86e59013792c196becb864fee2a3aebd146e..20a5cb4c039920e7a143489cf9d728c9f4cb28f4 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

@@ -1440,7 +1440,7 @@ class DetachToBrowserInSeparateDisplayTabDragControllerTest

DetachToBrowserInSeparateDisplayTabDragControllerTest() {}

virtual ~DetachToBrowserInSeparateDisplayTabDragControllerTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ virtual void SetUpCommandLine(base::CommandLine* command_line) override {

DetachToBrowserTabDragControllerTest::SetUpCommandLine(command_line);

// Make screens sufficiently wide to host 2 browsers side by side.

command_line->AppendSwitchASCII("ash-host-window-bounds",

@@ -1818,7 +1818,7 @@ class DifferentDeviceScaleFactorDisplayTabDragControllerTest

DifferentDeviceScaleFactorDisplayTabDragControllerTest() {}

virtual ~DifferentDeviceScaleFactorDisplayTabDragControllerTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ virtual void SetUpCommandLine(base::CommandLine* command_line) override {

DetachToBrowserTabDragControllerTest::SetUpCommandLine(command_line);

command_line->AppendSwitchASCII("ash-host-window-bounds",

"400x400,0+400-800x800*2");

@@ -1917,7 +1917,7 @@ class DetachToBrowserInSeparateDisplayAndCancelTabDragControllerTest

public:

DetachToBrowserInSeparateDisplayAndCancelTabDragControllerTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ virtual void SetUpCommandLine(base::CommandLine* command_line) override {

TabDragControllerTest::SetUpCommandLine(command_line);

command_line->AppendSwitchASCII("ash-host-window-bounds",

"0+0-250x250,251+0-250x250");