chrome/browser/first_run/first_run_internal_win.cc - Issue 816403003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/first_run_internal_win.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/first_run/first_run_browsertest.cc ('k') | chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/first_run_internal_win.cc

diff --git a/chrome/browser/first_run/first_run_internal_win.cc b/chrome/browser/first_run/first_run_internal_win.cc

index f66e95a23be80c34269a9007d019506870a18daf..d94e5e5a508b8976944c3d00e731129bd5b06a59 100644

--- a/chrome/browser/first_run/first_run_internal_win.cc

+++ b/chrome/browser/first_run/first_run_internal_win.cc

@@ -47,7 +47,7 @@ bool LaunchSetupForEula(const base::FilePath::StringType& value,

exe_dir = exe_dir.Append(installer::kInstallerDir);

base::FilePath exe_path = exe_dir.Append(installer::kSetupExe);

- CommandLine cl(CommandLine::NO_PROGRAM);

+ base::CommandLine cl(base::CommandLine::NO_PROGRAM);

cl.AppendSwitchNative(installer::switches::kShowEula, value);

if (base::win::IsMetroProcess()) {

@@ -63,7 +63,7 @@ bool LaunchSetupForEula(const base::FilePath::StringType& value,

SEE_MASK_FLAG_LOG_USAGE | SEE_MASK_FLAG_NO_UI);

return false;

} else {

- CommandLine setup_path(exe_path);

+ base::CommandLine setup_path(exe_path);

setup_path.AppendArguments(cl, false);

base::Process process =