chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc - Issue 816403003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

index b0d661350cc520a35b9f4db70e6ae9085256e9a0..c5861c07edd666e51222083eb20399a35eb01938 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

@@ -206,7 +206,7 @@ class CloudPrintProxyPolicyTest : public ::testing::Test {

: ui_thread_(content::BrowserThread::UI, &message_loop_) {

}

- bool LaunchBrowser(const CommandLine& command_line, Profile* profile) {

+ bool LaunchBrowser(const base::CommandLine& command_line, Profile* profile) {

int return_code = 0;

StartupBrowserCreator browser_creator;

return StartupBrowserCreator::ProcessCmdLineImpl(

@@ -461,7 +461,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartupBrowserCreatorWithCommandLine) {

CloudPrintProxyServiceFactory::GetInstance()->

SetTestingFactory(&profile_, TestCloudPrintProxyServiceFactory);

- CommandLine command_line(CommandLine::NO_PROGRAM);

+ base::CommandLine command_line(base::CommandLine::NO_PROGRAM);

command_line.AppendSwitch(switches::kCheckCloudPrintConnectorPolicy);

EXPECT_FALSE(LaunchBrowser(command_line, &profile_));