Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3363)

Unified Diff: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
diff --git a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
index 1f672e42be870fbb0a1c44709f8017f728c33bbb..806241dcaf6cbfcf5976ad8dec366e44393fc731 100644
--- a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
+++ b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
@@ -81,7 +81,8 @@ void ValidateBrowserWindowProperties(
EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchCommand,
prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
- CommandLine cmd_line(CommandLine::FromString(prop_var.get().pwszVal));
+ base::CommandLine cmd_line(
+ base::CommandLine::FromString(prop_var.get().pwszVal));
EXPECT_EQ(browser->profile()->GetPath().BaseName().value(),
cmd_line.GetSwitchValueNative(switches::kProfileDirectory));
prop_var.Reset();
@@ -120,7 +121,8 @@ void ValidateHostedAppWindowProperties(const Browser* browser,
S_OK,
pps->GetValue(PKEY_AppUserModel_RelaunchCommand, prop_var.Receive()));
EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
- CommandLine cmd_line(CommandLine::FromString(prop_var.get().pwszVal));
+ base::CommandLine cmd_line(
+ base::CommandLine::FromString(prop_var.get().pwszVal));
EXPECT_EQ(browser->profile()->GetPath().BaseName().value(),
cmd_line.GetSwitchValueNative(switches::kProfileDirectory));
EXPECT_EQ(base::UTF8ToWide(extension->id()),
@@ -167,7 +169,7 @@ class BrowserTestWithProfileShortcutManager : public InProcessBrowserTest {
public:
BrowserTestWithProfileShortcutManager() {}
- virtual void SetUpCommandLine(CommandLine* command_line) override {
+ virtual void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(switches::kEnableProfileShortcutManager);
}
@@ -180,7 +182,8 @@ class BrowserTestWithProfileShortcutManager : public InProcessBrowserTest {
IN_PROC_BROWSER_TEST_F(BrowserTestWithProfileShortcutManager,
DISABLED_WindowProperties) {
// Disable this test in Metro+Ash where Windows window properties aren't used.
- if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAshBrowserTests))
return;
// This test checks HWND properties that are only available on Win7+.
@@ -231,7 +234,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTestWithProfileShortcutManager,
IN_PROC_BROWSER_TEST_F(BrowserWindowPropertyManagerTest, DISABLED_HostedApp) {
#if defined(USE_ASH)
// Disable this test in Metro+Ash where Windows window properties aren't used.
- if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAshBrowserTests))
return;
#endif
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/frame/browser_window_property_manager_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698