chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc - Issue 816403003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

diff --git a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

index f48afaa52058b9043ede0cec4936b26f1b349a54..8054c2727c4b3e07462fd6c276a4a4c9b93259d1 100644

--- a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

+++ b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

@@ -48,8 +48,9 @@ QuitWithAppsController::QuitWithAppsController()

: notification_profile_(NULL), suppress_for_session_(false) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- hosted_app_quit_notification_ = CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kHostedAppQuitNotification);

+ hosted_app_quit_notification_ =

+ base::CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kHostedAppQuitNotification);

// There is only ever one notification to replace, so use the same replace_id

// each time.

@@ -124,8 +125,8 @@ bool QuitWithAppsController::ShouldQuit() {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

// Quit immediately if this is a test.

- if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType) &&

- !CommandLine::ForCurrentProcess()->HasSwitch(

+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType) &&

+ !base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kAppsKeepChromeAliveInTests)) {

return true;

}